Re: [PATCH v3 2/6] dt-bindings: media: camss: Add qcom,kaanapali-camss binding

Krzysztof Kozlowski
2025-10-28T18:39:27Z

On 28/10/2025 18:45, Vijay Kumar Tumati wrote:
>>>>> + - const: tfe1
>>>>> + - const: tfe2
>>>> Why not using the same names as before? It really does not matter that
>>>> it is thin or image, all of them are the same because only the
>>>> difference against top matters.
>>> Right, this is done to maintain the consistency with the clock driver on
>> Sorry, this makes no sense. This device has nothing to do with clock
>> driver. Don't ever use clock drivers as arguments for doing something in
>> completely different place.
>>
>> Not mentioning that drivers don't matter much for the bindings, so I
>> really do not get what you try to explain here.
>
> Understood. I meant to say that it is consistent with the naming for the
> TFE device that is available on Kaanapali. If our intention is to keep
> the names in the bindings same as previous generations despite the
> changing HW architectures, we could change these to IFEs, to be
> consistent with previous  generations. Please advise. Appreciate your
> inputs here.

You name these based on the provider, the clock controller or whatever
controller, and that's the mistake. Names are coming from this device
point of view, from the consumer. This device does not care whether this
is Thin or Image or Whatever GDSC.

Best regards,
Krzysztof