Re: [PATCH v4 2/5] i2c: piix4: Depends on X86

[Mario Limonciello <superm1@kernel.org>]

On 4/17/2025 5:16 PM, Andi Shyti wrote:
> Hi Mario,
> 
> On Mon, Apr 14, 2025 at 07:26:55PM -0500, Mario Limonciello wrote:
>> PIIX4 and compatible controllers are only for X86. As some headers are
>> being moved into x86 specific headers PIIX4 won't compile on non-x86.
>>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Closes: https://lore.kernel.org/oe-kbuild-all/202504120558.sq3IpWdH-lkp@intel.com/
>> Closes: https://lore.kernel.org/oe-kbuild-all/202504120432.0F8lOF3k-lkp@intel.com/
> 
> givent that the next patch is not merged anywhere yet, the above
> three tags are not needed.

Ah, thanks for clarifying this.  I'll strip them for the next version.

> 
> BTW, can I already take the two i2c patches?

If you don't mind I think it would be better to leave Acked-by tags for 
them and let these go through tip.

A few reasons:
1) The header rename this fits into happened on tip already.
2) Patch 5 which would go through tip depends on these two patches, so 
it would mean you need to provide an immutable branch for tip to merge.

But if you would rather do the immutable branch dance and take them now 
that's of course possible too.

> 
> Thanks,
> Andi
> 
>> Suggested-by: Ingo Molnar <mingo@kernel.org>
>> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>