Re: [PATCH] i2c: i2c-qcom-geni: Serve transfer during early resume stage

Mukesh Kumar Savaliya
2024-09-27T12:19:48Z

Hi Andi, sorry. Yes this is active. let me push V2 addressing comments
for V1. i was completely away earlier hence restarting now.

On 9/12/2024 3:32 PM, Andi Shyti wrote:
> Hi Mukesh,
>
> Is this patch still needed? Can anyone active in the Qualcomm
> drivers take a look?
>
> On Tue, Apr 02, 2024 at 03:57:41PM GMT, Mukesh Kumar Savaliya wrote:
>> pm_runtime_get_sync() function fails during PM early resume and returning
>> -EACCES because runtime PM for the device is disabled at the early stage
>> causing i2c transfer to fail. Make changes to serve transfer with force
>> resume.
>>
>> 1. Register interrupt with IRQF_EARLY_RESUME and IRQF_NO_SUSPEND flags
>> to avoid timeout of transfer when IRQ is not enabled during early stage.
>> 2. Do force resume if pm_runtime_get_sync() is failing after system
>> suspend when runtime PM is not enabled.
>> 3. Increment power usage count after forced resume to balance
>> it against regular runtime suspend.
>>
>> Co-developed-by: Viken Dadhaniya <quic_vdadhani@quicinc.com>
>> Signed-off-by: Viken Dadhaniya <quic_vdadhani@quicinc.com>
>> Signed-off-by: Mukesh Kumar Savaliya <quic_msavaliy@quicinc.com>
>
> Should this be considered a fix?
>
> Thanks,
> Andi