From: "Csókás Bence" <csokas.bence@prolan.hu>
To: Bjorn Andersson <bjorn.andersson@linaro.org>,
Vinod Koul <vkoul@kernel.org>
Cc: Wolfram Sang <wsa@kernel.org>, <linux-arm-msm@vger.kernel.org>,
Andy Gross <agross@kernel.org>,
Sumit Semwal <sumit.semwal@linaro.org>,
Douglas Anderson <dianders@chromium.org>,
Matthias Kaehlcke <mka@chromium.org>, <linux-i2c@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4] i2c: qcom-geni: Add support for GPI DMA
Date: Mon, 7 Jul 2025 09:59:14 +0200 [thread overview]
Message-ID: <86ccaef5-e55c-4c97-b7c2-6c65d4f6dcda@prolan.hu> (raw)
In-Reply-To: <YYAUfy2ary7ZJfK+@ripper>
Hi,
On 2021. 11. 01. 17:23, Bjorn Andersson wrote:
>> + if (ret < 0)
>> + goto err_tx;
>> +
>> + gi2c->rx_c = dma_request_chan(gi2c->se.dev, "rx");
>> + ret = dev_err_probe(gi2c->se.dev, IS_ERR(gi2c->rx_c), "Failed to get rx DMA ch\n");
>> + if (ret < 0)
>> + goto err_rx;
>> +
>> + dev_dbg(gi2c->se.dev, "Grabbed GPI dma channels\n");
>> + return 0;
>> +
>> +err_rx:
>> + dma_release_channel(gi2c->tx_c);
>
> Is there a reason why there's no devm_dma_request_chan()?
Just a heads-up: now there is, in dma/next! It was added in commit
08bf1663c21a.
Bence
next prev parent reply other threads:[~2025-07-07 7:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 6:01 [PATCH v4] i2c: qcom-geni: Add support for GPI DMA Vinod Koul
2021-11-01 16:23 ` Bjorn Andersson
2025-07-07 7:59 ` Csókás Bence [this message]
2021-11-03 2:13 ` Alexey Minnekhanov
2021-11-03 5:21 ` Vinod Koul
2021-11-04 2:44 ` Alexey Minnekhanov
[not found] <202110292307.Kb4i0Jf1-lkp@intel.com>
2021-10-31 14:05 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86ccaef5-e55c-4c97-b7c2-6c65d4f6dcda@prolan.hu \
--to=csokas.bence@prolan.hu \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=dianders@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=sumit.semwal@linaro.org \
--cc=vkoul@kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).