From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Jarzmik Subject: Re: [PATCH 04/12] i2c: pxa: Add support for pxa910/988 & new configuration features Date: Fri, 29 May 2015 22:22:27 +0200 Message-ID: <874mmvyvzw.fsf@belgarion.home> References: <1432818224-17070-1-git-send-email-vaibhav.hiremath@linaro.org> <1432818224-17070-5-git-send-email-vaibhav.hiremath@linaro.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <1432818224-17070-5-git-send-email-vaibhav.hiremath-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> (Vaibhav Hiremath's message of "Thu, 28 May 2015 18:33:36 +0530") Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Vaibhav Hiremath Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "Jett.Zhou" , Yi Zhang , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Wolfram Sang List-Id: linux-i2c@vger.kernel.org Vaibhav Hiremath writes: > @@ -167,6 +184,8 @@ struct pxa_i2c { > #define _ICR(i2c) ((i2c)->reg_icr) > #define _ISR(i2c) ((i2c)->reg_isr) > #define _ISAR(i2c) ((i2c)->reg_isar) > +#define _ILCR(i2c) ((i2c)->reg_ilcr) > +#define _IWCR(i2c) ((i2c)->reg_iwcr) > > /* > * I2C Slave mode address > @@ -467,11 +486,16 @@ static void i2c_pxa_reset(struct pxa_i2c *i2c) > if (i2c->reg_isar) > writel(i2c->slave_addr, _ISAR(i2c)); > #endif > - Not in this patch. > /* set control register values */ > writel(I2C_ICR_INIT | (i2c->fast_mode ? ICR_FM : 0), _ICR(i2c)); > writel(readl(_ICR(i2c)) | (i2c->high_mode ? ICR_HS : 0), _ICR(i2c)); > > + if (i2c->ilcr) > + writel(i2c->ilcr, _ILCR(i2c)); > + if (i2c->iwcr) > + writel(i2c->iwcr, _IWCR(i2c)); > + udelay(2); This is a magical 2us. Where does it come from ? Cheers. -- Robert