* [PATCH] I2C: OMAP: fix the clearing of interrupts
@ 2011-11-16 6:46 Shubhrajyoti D
[not found] ` <1321425992-6189-1-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Shubhrajyoti D @ 2011-11-16 6:46 UTC (permalink / raw)
To: linux-i2c-u79uwXL29TY76Z2rM5mHXA
Cc: linux-omap-u79uwXL29TY76Z2rM5mHXA, khilman-l0cyMroinI0,
ben-linux-elnMNo+KYs3YtjvyW6yDsg, Shubhrajyoti D, Vikram Pandita
The register IRQENABLE_CLR is a bit map of interrupt events.
All the bits have to be cleared to clear the interrupts.
Signed-off-by: Vikram Pandita <vikram.pandita-l0cyMroinI0@public.gmane.org>
Signed-off-by: Shubhrajyoti D <shubhrajyoti-l0cyMroinI0@public.gmane.org>
---
drivers/i2c/busses/i2c-omap.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
index 2dfb631..c7c6bb2 100644
--- a/drivers/i2c/busses/i2c-omap.c
+++ b/drivers/i2c/busses/i2c-omap.c
@@ -309,7 +309,7 @@ static void omap_i2c_idle(struct omap_i2c_dev *dev)
dev->iestate = omap_i2c_read_reg(dev, OMAP_I2C_IE_REG);
if (dev->rev >= OMAP_I2C_REV_ON_4430)
- omap_i2c_write_reg(dev, OMAP_I2C_IRQENABLE_CLR, 1);
+ omap_i2c_write_reg(dev, OMAP_I2C_IRQENABLE_CLR, 0x6FFF);
else
omap_i2c_write_reg(dev, OMAP_I2C_IE_REG, 0);
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] I2C: OMAP: fix the clearing of interrupts
[not found] ` <1321425992-6189-1-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
@ 2011-11-17 19:50 ` Kevin Hilman
0 siblings, 0 replies; 2+ messages in thread
From: Kevin Hilman @ 2011-11-17 19:50 UTC (permalink / raw)
To: Shubhrajyoti D
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA,
linux-omap-u79uwXL29TY76Z2rM5mHXA,
ben-linux-elnMNo+KYs3YtjvyW6yDsg, Vikram Pandita
Shubhrajyoti D <shubhrajyoti-l0cyMroinI0@public.gmane.org> writes:
> The register IRQENABLE_CLR is a bit map of interrupt events.
> All the bits have to be cleared to clear the interrupts.
>
> Signed-off-by: Vikram Pandita <vikram.pandita-l0cyMroinI0@public.gmane.org>
> Signed-off-by: Shubhrajyoti D <shubhrajyoti-l0cyMroinI0@public.gmane.org>
> ---
> drivers/i2c/busses/i2c-omap.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
> index 2dfb631..c7c6bb2 100644
> --- a/drivers/i2c/busses/i2c-omap.c
> +++ b/drivers/i2c/busses/i2c-omap.c
> @@ -309,7 +309,7 @@ static void omap_i2c_idle(struct omap_i2c_dev *dev)
>
> dev->iestate = omap_i2c_read_reg(dev, OMAP_I2C_IE_REG);
> if (dev->rev >= OMAP_I2C_REV_ON_4430)
> - omap_i2c_write_reg(dev, OMAP_I2C_IRQENABLE_CLR, 1);
> + omap_i2c_write_reg(dev, OMAP_I2C_IRQENABLE_CLR, 0x6FFF);
While fixing, please #define this mask, and add a comment to why all the
bits set in the mask.
Thanks,
Kevin
> else
> omap_i2c_write_reg(dev, OMAP_I2C_IE_REG, 0);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-11-17 19:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-16 6:46 [PATCH] I2C: OMAP: fix the clearing of interrupts Shubhrajyoti D
[not found] ` <1321425992-6189-1-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
2011-11-17 19:50 ` Kevin Hilman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).