From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-i2c@vger.kernel.org, Eric Miao <eric.y.miao@gmail.com>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Daniel Mack <daniel@zonque.org>,
Marek Vasut <marek.vasut@gmail.com>,
Philipp Zabel <philipp.zabel@gmail.com>,
Paul Parsons <lost.distance@yahoo.com>,
Jonathan Cameron <jic23@cam.ac.uk>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: pxa: move header file out of deprecated i2c folder
Date: Fri, 13 Oct 2017 22:59:16 +0200 [thread overview]
Message-ID: <87d15qlq6z.fsf@belgarion.home> (raw)
In-Reply-To: <20170814164303.2383-1-wsa@the-dreams.de> (Wolfram Sang's message of "Mon, 14 Aug 2017 18:43:01 +0200")
Wolfram Sang <wsa@the-dreams.de> writes:
> include/linux/i2c is deprecated because too many platform_data of i2c
> clients incorrectly ended up there. The few still relevant include files
> for I2C bus masters with their platform_data have been moved to the
> platform_data directory. This final one, PXA, is not entirely
> platform_data, so it is simply moved one layer up. After that, the i2c
> subfolder can finally go soon.
>
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> ---
>
> If you think this should rather go to "include/linux/platform_data" instead of
> "include/linux", I am open for that. I like the latter a tad better, but not
> super much.
>
> No runtime testing because of no HW, but buildbot is happy with this series at
> least and I did build testing, too.
Hi Wolfram,
I'm sorry I completely missed this one.
Either it's too late and trash this mail, or it's not, and then I'd suggest
another approach :
- patch 1 : move include/linux/i2c/pxa-i2c.h to include/platform_data/i2c-pxa.h
(i2c-pxa.h and not pxa-i2c.h to be consistent)
- patch 2 : move this chunk to arch/arm/mach-pxa/devices.h
> extern void pxa_set_i2c_info(struct i2c_pxa_platform_data *info);
>
> #ifdef CONFIG_PXA27x
> extern void pxa27x_set_i2c_power_info(struct i2c_pxa_platform_data *info);
> #endif
>
> #ifdef CONFIG_PXA3xx
> extern void pxa3xx_set_i2c_power_info(struct i2c_pxa_platform_data *info);
> #endif
This is the cleanest approach I could think of.
Cheers.
--
Robert
next prev parent reply other threads:[~2017-10-13 20:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-14 16:43 [PATCH] i2c: pxa: move header file out of deprecated i2c folder Wolfram Sang
2017-10-13 20:59 ` Robert Jarzmik [this message]
2017-10-13 21:45 ` Wolfram Sang
2017-10-29 17:52 ` Wolfram Sang
2017-10-29 20:34 ` Robert Jarzmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d15qlq6z.fsf@belgarion.home \
--to=robert.jarzmik@free.fr \
--cc=daniel@zonque.org \
--cc=eric.y.miao@gmail.com \
--cc=haojian.zhuang@gmail.com \
--cc=jic23@cam.ac.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lost.distance@yahoo.com \
--cc=marek.vasut@gmail.com \
--cc=philipp.zabel@gmail.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).