From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Korsgaard Subject: Re: [PATCH] i2c: let the core register devices from devicetree Date: Thu, 14 Jun 2012 09:31:49 +0200 Message-ID: <87ehpiwdqy.fsf@macbook.be.48ers.dk> References: <1339622215-4733-1-git-send-email-w.sang@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1339622215-4733-1-git-send-email-w.sang@pengutronix.de> (Wolfram Sang's message of "Wed, 13 Jun 2012 23:12:10 +0200") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Wolfram Sang Cc: Viresh Kumar , Mauro Carvalho Chehab , Tony Lindgren , Linus Walleij , Haojian Zhuang , Grant Likely , Laxman Dewangan , linux-i2c@vger.kernel.org, Kukjin Kim , Stephen Warren , Olof Johansson , Barry Song <21cnbao@gmail.com>, Jochen Friedrich , Deepak Sikri , Li Yang , Haavard Skinnemoen , Pawel Moll , Vitaly Wool , Wolfram Sang , Sascha Hauer , Rusty Russell , Tang Yuantian , "Jean Delvare (PC drivers, core)" , Magnus List-Id: linux-i2c@vger.kernel.org >>>>> "Wolfram" == Wolfram Sang writes: Wolfram> Currently, every driver has to do it on its own, but it should Wolfram> be done in the core, like we already do with board_info Wolfram> structs. Wolfram> Signed-off-by: Wolfram Sang Wolfram> --- Wolfram> Based on v3.5-rc2. Only build tested, I don't have a OF based device Wolfram> around at the moment. Neither have I, but it looks good. Acked-by: Peter Korsgaard Wolfram> @Peter: Why does ocores do the device registration manually via Wolfram> platform_data instead of using board_info? Because of dd14be4c274 (i2c-ocores: Can add I2C devices to the bus), a patch I wasn't CC'ed on and haven't acked. I only noticed it later when the I2C tree got merged into mainline. -- Bye, Peter Korsgaard