From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Jarzmik Subject: Re: [PATCH 10/12] i2c: pxa: Update debug function to dump more info on error Date: Fri, 29 May 2015 23:42:01 +0200 Message-ID: <87fv6fxdqu.fsf@belgarion.home> References: <1432818224-17070-1-git-send-email-vaibhav.hiremath@linaro.org> <1432818224-17070-11-git-send-email-vaibhav.hiremath@linaro.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <1432818224-17070-11-git-send-email-vaibhav.hiremath-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> (Vaibhav Hiremath's message of "Thu, 28 May 2015 18:33:42 +0530") Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Vaibhav Hiremath Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "Jett.Zhou" , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Wolfram Sang List-Id: linux-i2c@vger.kernel.org Vaibhav Hiremath writes: > Update i2c_pxa_scream_blue_murder() fn to print more information > in case of error. > > Signed-off-by: Jett.Zhou > [vaibhav.hiremath-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org: Split patches into logical changes > and update the Changelog] > Signed-off-by: Vaibhav Hiremath > Cc: Wolfram Sang > > Signed-off-by: Vaibhav Hiremath > --- > drivers/i2c/busses/i2c-pxa.c | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c > index cf6c383..065e647 100644 > --- a/drivers/i2c/busses/i2c-pxa.c > +++ b/drivers/i2c/busses/i2c-pxa.c > @@ -147,6 +147,7 @@ struct pxa_i2c { > unsigned int msg_idx; > unsigned int msg_ptr; > unsigned int slave_addr; > + unsigned int req_slave_addr; > > struct i2c_adapter adap; > struct clk *clk; > @@ -335,11 +336,13 @@ err_out: > static void i2c_pxa_scream_blue_murder(struct pxa_i2c *i2c, const char *why) > { > unsigned int i; > - printk(KERN_ERR "i2c: error: %s\n", why); > + printk(KERN_ERR"i2c: <%s> slave_0x%x error: %s\n", i2c->adap.name, > + i2c->req_slave_addr >> 1, why); Why not simply use dev_err(....) instead of adding manually i2c->adap.name ? Cheers. -- Robert