From: Petr Machata <petrm@nvidia.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: <netdev@vger.kernel.org>, <linux-i2c@vger.kernel.org>,
Ido Schimmel <idosch@nvidia.com>, Wolfram Sang <wsa@kernel.org>
Subject: Re: [PATCH 6/6] i2c: Make remove callback return void
Date: Wed, 29 Jun 2022 12:53:52 +0200 [thread overview]
Message-ID: <87h743vigq.fsf@nvidia.com> (raw)
In-Reply-To: <20220628140313.74984-7-u.kleine-koenig@pengutronix.de>
Uwe Kleine-König <u.kleine-koenig@pengutronix.de> writes:
> drivers/net/ethernet/mellanox/mlxsw/i2c.c | 4 +---
> diff --git a/drivers/net/ethernet/mellanox/mlxsw/i2c.c b/drivers/net/ethernet/mellanox/mlxsw/i2c.c
> index ce843ea91464..50b7121a5e3c 100644
> --- a/drivers/net/ethernet/mellanox/mlxsw/i2c.c
> +++ b/drivers/net/ethernet/mellanox/mlxsw/i2c.c
> @@ -656,14 +656,12 @@ static int mlxsw_i2c_probe(struct i2c_client *client,
> return err;
> }
>
> -static int mlxsw_i2c_remove(struct i2c_client *client)
> +static void mlxsw_i2c_remove(struct i2c_client *client)
> {
> struct mlxsw_i2c *mlxsw_i2c = i2c_get_clientdata(client);
>
> mlxsw_core_bus_device_unregister(mlxsw_i2c->core, false);
> mutex_destroy(&mlxsw_i2c->cmd.lock);
> -
> - return 0;
> }
>
> int mlxsw_i2c_driver_register(struct i2c_driver *i2c_driver)
For mlxsw:
Reviewed-by: Petr Machata <petrm@nvidia.com>
next prev parent reply other threads:[~2022-06-29 11:05 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220628140313.74984-1-u.kleine-koenig@pengutronix.de>
2022-06-28 14:03 ` [PATCH 1/6] drm/i2c/sil164: Drop no-op remove function Uwe Kleine-König
2022-06-28 14:03 ` [PATCH 2/6] leds: lm3697: Remove duplicated error reporting in .remove() Uwe Kleine-König
2022-06-28 14:03 ` [PATCH 3/6] leds: lm3601x: Don't use mutex after it was destroyed Uwe Kleine-König
2022-06-28 14:03 ` [PATCH 4/6] leds: lm3601x: Improve error reporting for problems during .remove() Uwe Kleine-König
2022-06-28 14:03 ` [PATCH 5/6] gpio: pca953x: Make platform teardown callback return void Uwe Kleine-König
2022-06-28 19:09 ` Andy Shevchenko
2022-06-28 20:15 ` Uwe Kleine-König
[not found] ` <20220628140313.74984-7-u.kleine-koenig@pengutronix.de>
[not found] ` <60cc6796236f23c028a9ae76dbe00d1917df82a5.camel@codeconstruct.com.au>
2022-06-29 7:23 ` [PATCH 6/6] i2c: Make remove " Uwe Kleine-König
2022-06-29 7:37 ` Javier Martinez Canillas
2022-06-29 7:55 ` Christophe Leroy
2022-06-29 8:09 ` Javier Martinez Canillas
2022-06-29 7:40 ` Heikki Krogerus
2022-06-29 10:40 ` Andy Shevchenko
2022-06-29 10:53 ` Petr Machata [this message]
[not found] ` <CAPAsAGwP4Mw_CJfsi7oapABdTBwO1HfiQux6X4UahspU74VjtQ@mail.gmail.com>
2022-06-29 13:35 ` Uwe Kleine-König
2022-06-29 14:25 ` Maximilian Luz
2022-06-29 21:20 ` Luca Ceresoli
2022-07-05 10:08 ` Jean Delvare
2022-07-05 10:36 ` Uwe Kleine-König
2022-07-06 9:13 ` Vladimir Oltean
2022-07-06 9:31 ` Uwe Kleine-König
2022-07-04 8:39 ` [PATCH 0/6] " Uwe Kleine-König
2022-07-16 15:15 ` Uwe Kleine-König
2022-07-18 4:18 ` Krzysztof Hałasa
2022-08-11 12:40 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h743vigq.fsf@nvidia.com \
--to=petrm@nvidia.com \
--cc=idosch@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).