Re: [PATCH] i2c: bcm2835: Set up the rising/falling edge delays

Eric Anholt
2018-02-21T22:03:28Z

[-- Attachment #1.1: Type: text/plain, Size: 1418 bytes --]

Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org> writes:

> [ Unknown signature status ]
> On Thu, Feb 08, 2018 at 02:54:05PM +0100, Boris Brezillon wrote:
>> From: Eric Anholt <eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org>
>>
>> We were leaving them in the power on state (or the state the firmware
>> had set up for some client, if we were taking over from them). The
>> boot state was 30 core clocks, when we actually want to sample some
>> time after (to make sure that the new input bit has actually arrived).
>>
>> Signed-off-by: Eric Anholt <eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org>
>> Signed-off-by: Boris Brezillon <boris.brezillon-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org>
>> Cc: Gerd Hoffmann <kraxel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>> ---
>> Hello,
>>
>> I'm reviving this patch that has been posted a while ago by Gerd.
>> It fixes EDID retrieval on some (broken?) HDMI displays, but I'm pretty
>> sure it will fix other I2C setup.
>>
>> Note that I also tested the change with a regular I2C device and it
>> worked just fine.
>
> Applied to for-current, thanks!
>
> Could you provide a Fixes tag if you think this should go to stable?

It would be a fix back to the start of the driver, but should apply
cleanly back to:

Fixes: 9446f62e8e18 ("i2c: bcm2835: Add support for dynamic clock")

and over a year ago seems like plenty of backport.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]