linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] omap4: i2c: add post idle reset registers flag
@ 2011-11-07 21:31 David Anders
       [not found] ` <1320701500-14535-1-git-send-email-x0132446-l0cyMroinI0@public.gmane.org>
  0 siblings, 1 reply; 4+ messages in thread
From: David Anders @ 2011-11-07 21:31 UTC (permalink / raw)
  To: danders.dev-Re5JQEeQqe8AvxtiuMwx3w,
	linux-omap-u79uwXL29TY76Z2rM5mHXA, tony-4v6yS6AI5VpBDgjK7y7TUQ,
	aneesh-l0cyMroinI0, jayabharath-l0cyMroinI0,
	andy.green-QSEj5FYQhm4dnm+yROfE0A, khilman-l0cyMroinI0,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA
  Cc: ben-linux-elnMNo+KYs3YtjvyW6yDsg, David Anders

omap44xx i2c devices need to have the registers reset post idle
similar to omap3xxx devices. this adds the additional flag for
OMAP_I2C_FLAG_RESET_REGS_POSTIDLE to the omap44xx i2c_dev_attr.

Signed-off-by: David Anders <x0132446-l0cyMroinI0@public.gmane.org>
---
 arch/arm/mach-omap2/omap_hwmod_44xx_data.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
index 7695e5d..e93dc40 100644
--- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
@@ -2257,7 +2257,8 @@ static struct omap_hwmod_class omap44xx_i2c_hwmod_class = {
 };
 
 static struct omap_i2c_dev_attr i2c_dev_attr = {
-	.flags	= OMAP_I2C_FLAG_BUS_SHIFT_NONE,
+	.flags	= OMAP_I2C_FLAG_RESET_REGS_POSTIDLE |
+		  OMAP_I2C_FLAG_BUS_SHIFT_NONE,
 };
 
 /* i2c1 */
-- 
1.7.0.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH v2] omap4: i2c: add post idle reset registers flag
       [not found] ` <1320701500-14535-1-git-send-email-x0132446-l0cyMroinI0@public.gmane.org>
@ 2011-11-08  8:11   ` Shubhrajyoti
       [not found]     ` <4EB8E445.4050604-l0cyMroinI0@public.gmane.org>
  0 siblings, 1 reply; 4+ messages in thread
From: Shubhrajyoti @ 2011-11-08  8:11 UTC (permalink / raw)
  To: David Anders
  Cc: danders.dev-Re5JQEeQqe8AvxtiuMwx3w,
	linux-omap-u79uwXL29TY76Z2rM5mHXA, tony-4v6yS6AI5VpBDgjK7y7TUQ,
	aneesh-l0cyMroinI0, jayabharath-l0cyMroinI0,
	andy.green-QSEj5FYQhm4dnm+yROfE0A, khilman-l0cyMroinI0,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA,
	ben-linux-elnMNo+KYs3YtjvyW6yDsg

On Tuesday 08 November 2011 03:01 AM, David Anders wrote:
> omap44xx i2c devices need to have the registers reset post idle
> similar to omap3xxx devices. this adds the additional flag for
> OMAP_I2C_FLAG_RESET_REGS_POSTIDLE to the omap44xx i2c_dev_attr.
Hello Anders a similar patch is already posted
http://www.spinics.net/lists/linux-i2c/msg05913.html

> Signed-off-by: David Anders <x0132446-l0cyMroinI0@public.gmane.org>
> ---
>  arch/arm/mach-omap2/omap_hwmod_44xx_data.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
> index 7695e5d..e93dc40 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
> @@ -2257,7 +2257,8 @@ static struct omap_hwmod_class omap44xx_i2c_hwmod_class = {
>  };
>  
>  static struct omap_i2c_dev_attr i2c_dev_attr = {
> -	.flags	= OMAP_I2C_FLAG_BUS_SHIFT_NONE,
> +	.flags	= OMAP_I2C_FLAG_RESET_REGS_POSTIDLE |
> +		  OMAP_I2C_FLAG_BUS_SHIFT_NONE,
>  };
>  
>  /* i2c1 */

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH v2] omap4: i2c: add post idle reset registers flag
       [not found]     ` <4EB8E445.4050604-l0cyMroinI0@public.gmane.org>
@ 2011-11-08 17:17       ` David Anders
  2011-11-08 19:55       ` Kevin Hilman
  1 sibling, 0 replies; 4+ messages in thread
From: David Anders @ 2011-11-08 17:17 UTC (permalink / raw)
  To: Shubhrajyoti
  Cc: danders.dev-Re5JQEeQqe8AvxtiuMwx3w,
	linux-omap-u79uwXL29TY76Z2rM5mHXA, tony-4v6yS6AI5VpBDgjK7y7TUQ,
	aneesh-l0cyMroinI0, jayabharath-l0cyMroinI0,
	andy.green-QSEj5FYQhm4dnm+yROfE0A, khilman-l0cyMroinI0,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA,
	ben-linux-elnMNo+KYs3YtjvyW6yDsg

On 11/08/2011 02:11 AM, Shubhrajyoti wrote:
> On Tuesday 08 November 2011 03:01 AM, David Anders wrote:
>    
>> omap44xx i2c devices need to have the registers reset post idle
>> similar to omap3xxx devices. this adds the additional flag for
>> OMAP_I2C_FLAG_RESET_REGS_POSTIDLE to the omap44xx i2c_dev_attr.
>>      
> Hello Anders a similar patch is already posted
> http://www.spinics.net/lists/linux-i2c/msg05913.html
>
>    

oops, i did a quick search of the mailing lists but didn't see your 
patch, so submitted this one.

are you going to babysit this one through?

>> Signed-off-by: David Anders<x0132446-l0cyMroinI0@public.gmane.org>
>> ---
>>   arch/arm/mach-omap2/omap_hwmod_44xx_data.c |    3 ++-
>>   1 files changed, 2 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
>> index 7695e5d..e93dc40 100644
>> --- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
>> +++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
>> @@ -2257,7 +2257,8 @@ static struct omap_hwmod_class omap44xx_i2c_hwmod_class = {
>>   };
>>
>>   static struct omap_i2c_dev_attr i2c_dev_attr = {
>> -	.flags	= OMAP_I2C_FLAG_BUS_SHIFT_NONE,
>> +	.flags	= OMAP_I2C_FLAG_RESET_REGS_POSTIDLE |
>> +		  OMAP_I2C_FLAG_BUS_SHIFT_NONE,
>>   };
>>
>>   /* i2c1 */
>>      
>    

Dave

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH v2] omap4: i2c: add post idle reset registers flag
       [not found]     ` <4EB8E445.4050604-l0cyMroinI0@public.gmane.org>
  2011-11-08 17:17       ` David Anders
@ 2011-11-08 19:55       ` Kevin Hilman
  1 sibling, 0 replies; 4+ messages in thread
From: Kevin Hilman @ 2011-11-08 19:55 UTC (permalink / raw)
  To: Shubhrajyoti
  Cc: David Anders, danders.dev-Re5JQEeQqe8AvxtiuMwx3w,
	linux-omap-u79uwXL29TY76Z2rM5mHXA, tony-4v6yS6AI5VpBDgjK7y7TUQ,
	aneesh-l0cyMroinI0, jayabharath-l0cyMroinI0,
	andy.green-QSEj5FYQhm4dnm+yROfE0A,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA,
	ben-linux-elnMNo+KYs3YtjvyW6yDsg

Shubhrajyoti <shubhrajyoti-l0cyMroinI0@public.gmane.org> writes:

> On Tuesday 08 November 2011 03:01 AM, David Anders wrote:
>> omap44xx i2c devices need to have the registers reset post idle
>> similar to omap3xxx devices. this adds the additional flag for
>> OMAP_I2C_FLAG_RESET_REGS_POSTIDLE to the omap44xx i2c_dev_attr.
>
> Hello Anders a similar patch is already posted
> http://www.spinics.net/lists/linux-i2c/msg05913.html

Benoit/Paul,

Can one of you queue the original hwmod data fix from Shubhrajyoti (link
above) for v3.2-rc1?

Thanks,

Kevin

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-11-08 19:55 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-07 21:31 [PATCH v2] omap4: i2c: add post idle reset registers flag David Anders
     [not found] ` <1320701500-14535-1-git-send-email-x0132446-l0cyMroinI0@public.gmane.org>
2011-11-08  8:11   ` Shubhrajyoti
     [not found]     ` <4EB8E445.4050604-l0cyMroinI0@public.gmane.org>
2011-11-08 17:17       ` David Anders
2011-11-08 19:55       ` Kevin Hilman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).