From: Kevin Hilman <khilman-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org>
To: Syed Rafiuddin <rafiuddin.syed-l0cyMroinI0@public.gmane.org>
Cc: linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] I2C:Moving Register Defines to Header File
Date: Wed, 13 May 2009 06:23:00 -0700 [thread overview]
Message-ID: <87octx9lxn.fsf@deeprootsystems.com> (raw)
In-Reply-To: <57428.192.168.10.89.1242203177.squirrel-pJFUjGLopx31T2qfsofKZtBPR1lH4CV8@public.gmane.org> (Syed Rafiuddin's message of "Wed\, 13 May 2009 13\:56\:17 +0530 \(IST\)")
"Syed Rafiuddin" <rafiuddin.syed-l0cyMroinI0@public.gmane.org> writes:
>> "Syed Rafiuddin" <rafiuddin.syed-l0cyMroinI0@public.gmane.org> writes:
>>
>>> This patch creates i2c-omap.h header and moves register and bit definition
>>> macros to it from i2c-omap.c
>>
>> Please use the description to describe the motivation for the changes
>> and the problems it is addressing/fixing.
>>
>> In other words, you described what your patch does but not why.
>
> The intention of the patch is to have a separate header which will have omap3
> and omap4 related register definitions. As omap4 has different offset addresses
> with respect to omap3,adding omap4 related stuff in the same file will leave
> the file look ugly.
IMO, The regs do not need to move to a separate header unless they will
be used outside of i2c-omap.c.
Kevin
next prev parent reply other threads:[~2009-05-13 13:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <52671.192.168.10.89.1242133785.squirrel@dbdmail.itg.ti.com>
[not found] ` <52671.192.168.10.89.1242133785.squirrel-pJFUjGLopx31T2qfsofKZtBPR1lH4CV8@public.gmane.org>
2009-05-12 13:13 ` [PATCH] I2C:Moving Register Defines to Header File Felipe Balbi
2009-05-12 15:01 ` Kevin Hilman
[not found] ` <87hbzqe55y.fsf-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org>
2009-05-13 8:26 ` Syed Rafiuddin
[not found] ` <57428.192.168.10.89.1242203177.squirrel-pJFUjGLopx31T2qfsofKZtBPR1lH4CV8@public.gmane.org>
2009-05-13 13:23 ` Kevin Hilman [this message]
[not found] ` <87octx9lxn.fsf-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org>
2009-05-14 10:34 ` Jagadeesh Bhaskar Pakaravoor
2009-05-14 20:40 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87octx9lxn.fsf@deeprootsystems.com \
--to=khilman-1d3hcaltpluheniveurvkkeocmrvltnr@public.gmane.org \
--cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=rafiuddin.syed-l0cyMroinI0@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).