From: Kevin Hilman <khilman@deeprootsystems.com>
To: me@felipebalbi.com
Cc: balajitk@ti.com, linux-kernel@vger.kernel.org, tony@atomide.com,
david-b@pacbell.net, linux-omap@vger.kernel.org,
linux-i2c@vger.kernel.org, sameo@openedhand.com, wim@iguana.be,
timo.t.kokkonen@nokia.com, ben-linux@fluff.org,
lrg@slimlogic.co.uk, broonie@opensource.wolfsonmicro.com,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Rajendra Nayak <rnayak@ti.com>
Subject: Re: [PATCH 1/4] ARM: OMAP: Rename twl4030* driver files to enable re-use
Date: Wed, 22 Jul 2009 07:54:01 -0700 [thread overview]
Message-ID: <87prbslqeu.fsf@deeprootsystems.com> (raw)
In-Reply-To: <20090720185253.GA7984@gandalf> (Felipe Balbi's message of "Mon\, 20 Jul 2009 21\:52\:54 +0300")
Felipe Balbi <me@felipebalbi.com> writes:
> Hi,
>
> On Mon, Jul 20, 2009 at 07:01:11PM +0530, balajitk@ti.com wrote:
>> From: Santosh Shilimkar <santosh.shilimkar@ti.com>
>>
>> The upcoming TWL6030 is companion chip for OMAP4 like the current TWL4030
>> for OMAP3. The common modules like RTC, Regulator creates opportunity
>> to re-use the most of the code from twl4030.
>>
>> This patch renames few common drivers twl4030* files to twl* to enable
>> the code re-use.
>>
>> Signed-off-by: Rajendra Nayak <rnayak@ti.com>
>> Signed-off-by: Balaji T K <balajitk@ti.com>
>> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
>> ---
>> arch/arm/mach-omap2/board-2430sdp.c | 2 +-
>> arch/arm/mach-omap2/board-3430sdp.c | 2 +-
>> arch/arm/mach-omap2/board-ldp.c | 2 +-
>> arch/arm/mach-omap2/board-omap3beagle.c | 2 +-
>> arch/arm/mach-omap2/board-omap3pandora.c | 2 +-
>> arch/arm/mach-omap2/board-overo.c | 2 +-
>> drivers/gpio/twl4030-gpio.c | 2 +-
>> drivers/mfd/Makefile | 2 +-
>> drivers/mfd/{twl4030-core.c => twl-core.c} | 8 +++-----
>> drivers/mfd/twl4030-irq.c | 2 +-
>> drivers/regulator/Makefile | 2 +-
>> .../{twl4030-regulator.c => twl-regulator.c} | 6 +++---
>> drivers/rtc/Makefile | 2 +-
>> drivers/rtc/{rtc-twl4030.c => rtc-twl.c} | 2 +-
>> drivers/usb/otg/twl4030-usb.c | 2 +-
>> include/linux/i2c/{twl4030.h => twl.h} | 5 ++++-
>> sound/soc/codecs/twl4030.c | 2 +-
>
> this is kinda useless, we can consider twl6030 as being sw compatible
> (almost) with twl4030. And twl4030 driver already support plenty of
> other devices, just look at drivers/mfd/twl4030-core.c lines 807 - 814.
> We have twl4003, twl5030, tps65950, tps65930 and tps65920.
>
> So IMO, renaming the files is unnecessary.
I support the renaming.
I think the renaming part of a cleanup and a generalization so that
this code can be reused for other parts in the same family, and still
be readable and maintainable.
Yes, we *could* keep the current names, but that's a shortcut that
will lead to code that is more difficult to follow and thus maintain.
Kevin
prev parent reply other threads:[~2009-07-22 14:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-20 13:31 [PATCH 1/4] ARM: OMAP: Rename twl4030* driver files to enable re-use balajitk-l0cyMroinI0
2009-07-20 18:52 ` Felipe Balbi
2009-07-21 4:31 ` Shilimkar, Santosh
2009-07-21 5:24 ` Felipe Balbi
2009-07-21 5:33 ` Shilimkar, Santosh
2009-07-22 14:54 ` Kevin Hilman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87prbslqeu.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=balajitk@ti.com \
--cc=ben-linux@fluff.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=david-b@pacbell.net \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=me@felipebalbi.com \
--cc=rnayak@ti.com \
--cc=sameo@openedhand.com \
--cc=santosh.shilimkar@ti.com \
--cc=timo.t.kokkonen@nokia.com \
--cc=tony@atomide.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).