Re: [PATCH] OMAP4: I2C : I2C context save

Re: [PATCH] OMAP4: I2C : I2C context save

[Kevin Hilman]

Shubhrajyoti D <shubhrajyoti@ti.com> writes:

> Restore of context is not done for OMAP4. This patch 

Subject says context *save*, here says context *restore.*

> adds the OMAP_I2C_FLAG_RESET_REGS_POSTIDLE in the OMAP4
> hwmod which activates the restore for OMAP4.

s/hwmod/hwmod data/

> Currently the OMAP4 doesnot hit device off still the

s/doesnot/does not/

> driver may have support for it.

Also, since this is a patch to the hwmod data, the subject
prefix should be something like:

OMAP4: hwmod_data: I2C: set flag to restore context

or something similar.

Also, this is the 2nd (or maybe 3rd) version of this patch posted.
Please version the patch using [PATCH vN].

Kevin

> Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
> ---
> Applies on top of patches from Andy Green
> http://www.spinics.net/lists/linux-i2c/msg05632.html
> Tested on OMAP4430
>
>  arch/arm/mach-omap2/omap_hwmod_44xx_data.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
> index 0fe9556..5e2c748 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
> @@ -2130,7 +2130,8 @@ static struct omap_hwmod_class omap44xx_i2c_hwmod_class = {
>  };
>  
>  static struct omap_i2c_dev_attr i2c_dev_attr = {
> -	.flags  = OMAP_I2C_FLAG_BUS_SHIFT_NONE,
> +	.flags  = OMAP_I2C_FLAG_BUS_SHIFT_NONE |
> +			OMAP_I2C_FLAG_RESET_REGS_POSTIDLE,
>  };
>  
>  /* i2c1 */

[PATCH] OMAP4: I2C : I2C context save

[Shubhrajyoti D]

Restore of context is not done for OMAP4. This patch 
adds the OMAP_I2C_FLAG_RESET_REGS_POSTIDLE in the OMAP4
hwmod which activates the restore for OMAP4.
Currently the OMAP4 doesnot hit device off still the
driver may have support for it.

Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
---
Applies on top of patches from Andy Green
http://www.spinics.net/lists/linux-i2c/msg05632.html
Tested on OMAP4430

 arch/arm/mach-omap2/omap_hwmod_44xx_data.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
index 0fe9556..5e2c748 100644
--- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
@@ -2130,7 +2130,8 @@ static struct omap_hwmod_class omap44xx_i2c_hwmod_class = {
 };
 
 static struct omap_i2c_dev_attr i2c_dev_attr = {
-	.flags  = OMAP_I2C_FLAG_BUS_SHIFT_NONE,
+	.flags  = OMAP_I2C_FLAG_BUS_SHIFT_NONE |
+			OMAP_I2C_FLAG_RESET_REGS_POSTIDLE,
 };
 
 /* i2c1 */
-- 
1.7.1