From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Wolfram Sang <wsa@kernel.org>,
linux-i2c@vger.kernel.org,
Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: John Stultz <john.stultz@linaro.org>
Subject: Re: [PATCH v1] i2c: designware: Adjust bus speed independently of ACPI
Date: Tue, 23 Jun 2020 14:21:18 +0300 [thread overview]
Message-ID: <89518c6c-f687-c45a-0315-a188d85d333a@linux.intel.com> (raw)
In-Reply-To: <20200623091501.50070-1-andriy.shevchenko@linux.intel.com>
On 6/23/20 12:15 PM, Andy Shevchenko wrote:
> John Stultz reported that commit f9288fcc5c615 ("i2c: designware: Move
> ACPI parts into common module") caused a regression on the HiKey board
> where adv7511 HDMI bridge driver wasn't probing anymore due the I2C bus
> failed to start.
>
> It seems the change caused the bus speed being zero when CONFIG_ACPI
> not set and neither speed based on "clock-frequency" device property
> or default fast mode is set.
>
> Fix this by splitting i2c_dw_acpi_adjust_bus_speed() to
> i2c_dw_acpi_round_bus_speed() and i2c_dw_adjust_bus_speed(), where
> the latter one has the code that runs independently of ACPI.
>
> Fixes: f9288fcc5c615 ("i2c: designware: Move ACPI parts into common module")
> Reported-by: John Stultz <john.stultz@linaro.org>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/i2c/busses/i2c-designware-common.c | 25 ++++++++++++++-------
> drivers/i2c/busses/i2c-designware-core.h | 3 +--
> drivers/i2c/busses/i2c-designware-pcidrv.c | 2 +-
> drivers/i2c/busses/i2c-designware-platdrv.c | 2 +-
> 4 files changed, 20 insertions(+), 12 deletions(-)
>
Looks good to me. Let's wait for John's test result.
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
next prev parent reply other threads:[~2020-06-23 11:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-23 9:15 [PATCH v1] i2c: designware: Adjust bus speed independently of ACPI Andy Shevchenko
2020-06-23 11:21 ` Jarkko Nikula [this message]
2020-06-23 17:35 ` John Stultz
2020-06-23 19:25 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89518c6c-f687-c45a-0315-a188d85d333a@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=john.stultz@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).