From: Samuel Holland <samuel.holland@sifive.com>
To: Troy Mitchell <troymitchell988@gmail.com>
Cc: andi.shyti@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, linux-i2c@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org,
Krzysztof Kozlowski <krzk@kernel.org>
Subject: Re: [PATCH v2 1/2] dt-bindings: i2c: spacemit: add support for K1 SoC
Date: Mon, 4 Nov 2024 20:50:52 -0600 [thread overview]
Message-ID: <8a04f84b-453b-44e5-9053-204a08d38e19@sifive.com> (raw)
In-Reply-To: <a08384bf-6747-4975-b025-f8fd3685fc30@gmail.com>
Hi Troy,
On 2024-11-04 7:14 PM, Troy Mitchell wrote:
>
> On 2024/11/4 22:48, Krzysztof Kozlowski wrote:
>> On 04/11/2024 14:01, Troy Mitchell wrote:
>>>
>>> On 2024/10/31 16:00, Krzysztof Kozlowski wrote:
>>>> On Tue, Oct 29, 2024 at 04:36:00PM +0800, Troy Mitchell wrote:
>>>>> On 2024/10/28 15:38, Krzysztof Kozlowski wrote:
>>>>>> On Mon, Oct 28, 2024 at 01:32:19PM +0800, Troy Mitchell wrote:
>>>>>>> The I2C of K1 supports fast-speed-mode and high-speed-mode,
>>>>>>> and supports FIFO transmission.
>>>>>>>
>>>>>>> Signed-off-by: Troy Mitchell <TroyMitchell988@gmail.com>
>>>>>>> ---
>>> Change in v2:
>>> - Change the maxItems of reg from 1 to 2 in properties
>>
>> Why?
> I need the address and size. In v1, I wrote it as 1, and I got the make
> dt_binding_check error.
One "<address size>" element is just one item. maxItems > 1 would be for
hardware with multiple discontiguous register ranges: <address1 size1>,
<address2 size2>.
Regards,
Samuel
next prev parent reply other threads:[~2024-11-05 2:50 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-28 5:32 [PATCH v2 0/2] riscv: spacemit: add i2c support to K1 SoC Troy Mitchell
2024-10-28 5:32 ` [PATCH v2 1/2] dt-bindings: i2c: spacemit: add support for " Troy Mitchell
2024-10-28 7:38 ` Krzysztof Kozlowski
2024-10-29 8:36 ` Troy Mitchell
2024-10-31 8:00 ` Krzysztof Kozlowski
2024-11-01 14:29 ` Jesse T
2024-11-01 14:37 ` Krzysztof Kozlowski
2024-11-04 13:01 ` Troy Mitchell
2024-11-04 14:48 ` Krzysztof Kozlowski
2024-11-05 1:14 ` Troy Mitchell
2024-11-05 2:50 ` Samuel Holland [this message]
2024-11-05 5:20 ` Troy Mitchell
2024-10-31 8:01 ` Krzysztof Kozlowski
2024-11-02 3:48 ` Samuel Holland
2024-11-06 7:58 ` Troy Mitchell
2024-11-07 0:29 ` Samuel Holland
2024-11-07 1:57 ` Troy Mitchell
2024-11-24 19:18 ` Haylen Chu
2024-10-28 5:32 ` [PATCH v2 2/2] i2c: spacemit: add support for SpacemiT " Troy Mitchell
2024-10-28 12:51 ` kernel test robot
2024-10-28 14:45 ` kernel test robot
2024-11-04 13:01 ` Troy Mitchell
2024-11-05 6:50 ` Troy Mitchell
2024-10-31 11:43 ` [PATCH v2 0/2] riscv: spacemit: add i2c support to " Andi Shyti
2024-11-04 12:23 ` Troy Mitchell
2024-11-05 14:21 ` Andi Shyti
2024-11-06 7:59 ` Troy Mitchell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a04f84b-453b-44e5-9053-204a08d38e19@sifive.com \
--to=samuel.holland@sifive.com \
--cc=andi.shyti@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=robh@kernel.org \
--cc=troymitchell988@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox