From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84927C43334 for ; Wed, 15 Jun 2022 16:06:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245083AbiFOQG6 (ORCPT ); Wed, 15 Jun 2022 12:06:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33228 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240929AbiFOQG5 (ORCPT ); Wed, 15 Jun 2022 12:06:57 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C3E0927FF7; Wed, 15 Jun 2022 09:06:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID: Sender:Reply-To:Content-ID:Content-Description; bh=0pNvw0AJcxHmfaL+wnn2XxzmONSyI3eLqIqKcEGrFlw=; b=WcWMflq4H7j2sfihg3TcYEVX0P Uq635gc6KnkYqaXJG5B40FHlqXz2Npw+ty5+wnBhzUajcJZzyo8kZ4B0FxoQOLWX6gwZaA8r27CKG Zf9fm7vsenwBF05ChbGAHVfadgmjpALv+hcB+vymHa4b3VBcdCoZo3F7UlE78nFYinH9zvbsXqDkp 5iub0T/QhUYuCZmbweUh/h/7MTrdMw2IXMpxX5a0tyLXGa0r3rct/jLuwbq6+NA0epnqqkJC+Pr60 6tyJHfW04fLihHOQHr6yn9D7nBHpYHlQFpc4gjP++oQ9AtwDwOjju4Ywqg3SF/Bb8CF+U36YJc7cu puLPU5PQ==; Received: from [2601:1c0:6280:3f0::aa0b] by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1VX9-008ALV-3I; Wed, 15 Jun 2022 16:06:19 +0000 Message-ID: <8b7841a9-9313-b1d5-8a80-a65cfa8e7b4d@infradead.org> Date: Wed, 15 Jun 2022 09:06:05 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v8 1/3] ipmi: ssif_bmc: Add SSIF BMC driver Content-Language: en-US To: Quan Nguyen , Corey Minyard , Rob Herring , Krzysztof Kozlowski , Brendan Higgins , Benjamin Herrenschmidt , Joel Stanley , Andrew Jeffery , Wolfram Sang , openipmi-developer@lists.sourceforge.net, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, openbmc@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org Cc: Open Source Submission , Phong Vo , "Thang Q . Nguyen" References: <20220615090259.1121405-1-quan@os.amperecomputing.com> <20220615090259.1121405-2-quan@os.amperecomputing.com> From: Randy Dunlap In-Reply-To: <20220615090259.1121405-2-quan@os.amperecomputing.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On 6/15/22 02:02, Quan Nguyen wrote: > diff --git a/drivers/char/ipmi/Kconfig b/drivers/char/ipmi/Kconfig > index b061e6b513ed..18a89093d64e 100644 > --- a/drivers/char/ipmi/Kconfig > +++ b/drivers/char/ipmi/Kconfig > @@ -169,6 +169,17 @@ config ASPEED_BT_IPMI_BMC > found on Aspeed SOCs (AST2400 and AST2500). The driver > implements the BMC side of the BT interface. > > +config SSIF_IPMI_BMC > + tristate "SSIF IPMI BMC driver" > + select I2C No. That should be: depends on I2C We don't select an entire subsystem just to satisfy one driver. > + select I2C_SLAVE > + help > + This enables the IPMI SMBus system interface (SSIF) at the > + management (BMC) side. > + > + The driver implements the BMC side of the SMBus system > + interface (SSIF). > + Thanks. -- ~Randy