From: "Sverdlin, Alexander" <alexander.sverdlin@siemens.com>
To: "alexander.stein@ew.tq-group.com" <alexander.stein@ew.tq-group.com>
Cc: "linux-imx@nxp.com" <linux-imx@nxp.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"aisheng.dong@nxp.com" <aisheng.dong@nxp.com>
Subject: Re: [PATCH v3] i2c: lpi2c: cache peripheral clock rate
Date: Mon, 15 May 2023 12:37:17 +0000 [thread overview]
Message-ID: <8ba04ce7b28d587e9713b35dd564c8158acb2eb5.camel@siemens.com> (raw)
In-Reply-To: <8299946.T7Z3S40VBb@steina-w>
Hello Alexander!
On Mon, 2023-05-15 at 14:32 +0200, Alexander Stein wrote:
> > stack backtrace:
> > CPU: 1 PID: 2238 Comm: xxxxxxx Tainted: G O
> > 5.15.71+git8e43aee #1
> > Hardware name: Siemens PXC5.E24 (DT)
> > Call trace:
> > dump_backtrace+0x0/0x1d4
> > show_stack+0x20/0x2c
> > dump_stack_lvl+0x8c/0xb8
> > dump_stack+0x18/0x34
> > print_circular_bug+0x1f8/0x200
> > check_noncircular+0x130/0x144
> > __lock_acquire+0x12a4/0x20a0
> > lock_acquire.part.0+0xe0/0x230
> > lock_acquire+0x68/0x84
> > __mutex_lock+0xa8/0x4d0
> > mutex_lock_nested+0x48/0x54
> > __setup_irq+0xbc/0x8bc
> > request_threaded_irq+0xf4/0x1b4
> > devm_request_threaded_irq+0x88/0x104
> > lpi2c_runtime_resume+0x70/0xe4
>
> It seems your (possible) deadlock is triggered along
> devm_request_irq() during
> resume.
You are right! Thank you for looking into this!
> As mainline just enables the clocks, there is nothing we can do here.
> Your
> patch still is sensible, can you send a new version with the review
> addressed?
Sure, I'll do!
--
Alexander Sverdlin
Siemens AG
www.siemens.com
next prev parent reply other threads:[~2023-05-15 12:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 13:08 [PATCH v3] i2c: lpi2c: cache peripheral clock rate A. Sverdlin
2023-04-21 13:48 ` Alexander Stein
2023-04-21 13:59 ` Marc Kleine-Budde
2023-04-24 7:03 ` Alexander Stein
2023-04-30 7:05 ` Wolfram Sang
2023-05-02 6:50 ` Alexander Stein
2023-05-02 7:03 ` Marc Kleine-Budde
2023-04-21 14:10 ` Sverdlin, Alexander
2023-05-15 9:11 ` Alexander Stein
2023-05-15 12:04 ` Sverdlin, Alexander
2023-05-15 12:32 ` Alexander Stein
2023-05-15 12:37 ` Sverdlin, Alexander [this message]
2023-05-15 13:11 ` Sverdlin, Alexander
2023-04-24 8:08 ` Alexander Stein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ba04ce7b28d587e9713b35dd564c8158acb2eb5.camel@siemens.com \
--to=alexander.sverdlin@siemens.com \
--cc=aisheng.dong@nxp.com \
--cc=alexander.stein@ew.tq-group.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox