From: Thomas Richard <thomas.richard@bootlin.com>
To: Lee Jones <lee@kernel.org>
Cc: Andi Shyti <andi.shyti@kernel.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Werner Gartner <Werner.Gartner@congatec.com>,
mfd@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH v4 5/9] mfd: cgbc: Use real I2C bus names
Date: Thu, 15 Oct 2026 19:23:20 +0200 [thread overview]
Message-ID: <8eaed3d4-218b-4abd-853a-108443f3ecd2@bootlin.com> (raw)
In-Reply-To: <20261015152700.GA2048969@google.com>
>> diff --git a/drivers/mfd/cgbc-core.c b/drivers/mfd/cgbc-core.c
>> index 8522df882509..a58d9ffdc277 100644
>> --- a/drivers/mfd/cgbc-core.c
>> +++ b/drivers/mfd/cgbc-core.c
>> @@ -55,13 +55,13 @@
>>
>> static struct platform_device *cgbc_pdev;
>>
>> -static const struct cgbc_i2c_platform_data cgbc_i2c_gp_pdata = {
>> - .name = "Congatec General Purpose I2C adapter",
>
> This is odd. We only just added these.
>
> This should be fixed up into the original patch.
>
Indeed I can fix names earlier in the series, when I2C bus names are
defined in the I2C driver, so no need to rename variables in the MFD.
Best Regards,
Thomas
next prev parent reply other threads:[~2026-10-15 17:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-02 11:12 [PATCH v4 0/9] Congatec Board Controller: Add storage devices support Thomas Richard (congatec GmbH)
2026-10-02 11:12 ` [PATCH v4 1/9] mfd: cgbc: Fix use of negative error code as valid session handle Thomas Richard (congatec GmbH)
2026-10-15 15:19 ` Lee Jones
2026-10-15 17:53 ` Thomas Richard
2026-10-02 11:12 ` [PATCH v4 2/9] mfd: cgbc: Add I2C platform data Thomas Richard (congatec GmbH)
2026-10-02 11:12 ` [PATCH v4 3/9] i2c: cgbc: Use plateform data to get bus ID and adapter name Thomas Richard (congatec GmbH)
2026-10-02 11:12 ` [PATCH v4 4/9] mfd: cgbc: Use PLATFORM_DEVID_AUTO for child device registration Thomas Richard (congatec GmbH)
2026-10-15 15:27 ` Lee Jones
2026-10-15 17:48 ` Thomas Richard
2026-10-02 11:12 ` [PATCH v4 5/9] mfd: cgbc: Use real I2C bus names Thomas Richard (congatec GmbH)
2026-10-15 15:27 ` Lee Jones
2026-10-15 17:23 ` Thomas Richard [this message]
2026-10-02 11:12 ` [PATCH v4 6/9] i2c: cgbc: Add support for fixed frequency buses Thomas Richard (congatec GmbH)
2026-10-02 11:12 ` [PATCH v4 7/9] mfd: cgbc: Add virtual I2C bus support Thomas Richard (congatec GmbH)
2026-10-02 11:12 ` [PATCH v4 8/9] mfd: cgbc: Add virtual storage devices on the virtual I2C bus Thomas Richard (congatec GmbH)
2026-10-02 11:12 ` [PATCH v4 9/9] i2c: cgbc: Register known I2C devices on the bus Thomas Richard (congatec GmbH)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8eaed3d4-218b-4abd-853a-108443f3ecd2@bootlin.com \
--to=thomas.richard@bootlin.com \
--cc=Werner.Gartner@congatec.com \
--cc=andi.shyti@kernel.org \
--cc=lee@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mfd@lists.linux.dev \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox