* [PATCH] i2c: nomadik: constify amba_id
@ 2017-08-23 17:20 Arvind Yadav
2017-08-29 20:35 ` Wolfram Sang
0 siblings, 1 reply; 2+ messages in thread
From: Arvind Yadav @ 2017-08-23 17:20 UTC (permalink / raw)
To: rubini, linus.walleij, wsa; +Cc: linux-kernel, linux-arm-kernel, linux-i2c
amba_id are not supposed to change at runtime. All functions
working with const amba_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/i2c/busses/i2c-nomadik.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-nomadik.c b/drivers/i2c/busses/i2c-nomadik.c
index da6609d..49c7c0c 100644
--- a/drivers/i2c/busses/i2c-nomadik.c
+++ b/drivers/i2c/busses/i2c-nomadik.c
@@ -1088,7 +1088,7 @@ static struct i2c_vendor_data vendor_db8500 = {
.fifodepth = 32, /* Guessed from TFTR/RFTR = 15 */
};
-static struct amba_id nmk_i2c_ids[] = {
+static const struct amba_id nmk_i2c_ids[] = {
{
.id = 0x00180024,
.mask = 0x00ffffff,
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] i2c: nomadik: constify amba_id
2017-08-23 17:20 [PATCH] i2c: nomadik: constify amba_id Arvind Yadav
@ 2017-08-29 20:35 ` Wolfram Sang
0 siblings, 0 replies; 2+ messages in thread
From: Wolfram Sang @ 2017-08-29 20:35 UTC (permalink / raw)
To: Arvind Yadav
Cc: rubini, linus.walleij, linux-kernel, linux-arm-kernel, linux-i2c
[-- Attachment #1: Type: text/plain, Size: 295 bytes --]
On Wed, Aug 23, 2017 at 10:50:50PM +0530, Arvind Yadav wrote:
> amba_id are not supposed to change at runtime. All functions
> working with const amba_id. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-29 20:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-23 17:20 [PATCH] i2c: nomadik: constify amba_id Arvind Yadav
2017-08-29 20:35 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).