Linux I2C development
 help / color / mirror / Atom feed
From: Sushrut Shree Trivedi <quic_sushruts@quicinc.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
	Wasim Nazir <wasim.nazir@oss.qualcomm.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	"Rob Herring" <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	"Konrad Dybcio" <konradybcio@kernel.org>,
	Richard Cochran <richardcochran@gmail.com>,
	Bartosz Golaszewski <brgl@bgdev.pl>
Cc: <kernel@oss.qualcomm.com>, <linux-mmc@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-msm@vger.kernel.org>, <netdev@vger.kernel.org>,
	<linux-i2c@vger.kernel.org>
Subject: Re: [PATCH v4 07/14] arm64: dts: qcom: lemans-evk: Enable PCIe support
Date: Mon, 15 Sep 2025 16:03:14 +0530	[thread overview]
Message-ID: <8f8df889-3f88-4b9b-a238-16044796d897@quicinc.com> (raw)
In-Reply-To: <cb2a5c93-0643-4c6b-a97f-b947c9aad32c@oss.qualcomm.com>


On 9/12/2025 5:57 PM, Konrad Dybcio wrote:
> On 9/8/25 10:19 AM, Wasim Nazir wrote:
>> From: Sushrut Shree Trivedi <quic_sushruts@quicinc.com>
>>
>> Enable PCIe0 and PCIe1 along with the respective phy-nodes.
>>
>> PCIe0 is routed to an m.2 E key connector on the mainboard for wifi
>> attaches while PCIe1 routes to a standard PCIe x4 expansion slot.
>>
>> Signed-off-by: Sushrut Shree Trivedi <quic_sushruts@quicinc.com>
>> Signed-off-by: Wasim Nazir <wasim.nazir@oss.qualcomm.com>
>> ---
> [...]
>
>> +		perst-pins {
>> +			pins = "gpio2";
>> +			function = "gpio";
>> +			drive-strength = <2>;
>> +			bias-pull-down;
>> +		};
> Pulling down an active-low pin is a bad idea

Ack, we should do pull up.
we took reference from the previous targets which seems to be wrong.
we will make it pull up.

Bjorn,
can you make this change while applying or shall we send new series.

- Sushrut

>
> Konrad

  reply	other threads:[~2025-09-15 10:33 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-08  8:19 [PATCH v4 00/14] arm64: dts: qcom: lemans-evk: Extend board support for additional peripherals Wasim Nazir
2025-09-08  8:19 ` [PATCH v4 01/14] dt-bindings: mmc: sdhci-msm: Document the Lemans compatible Wasim Nazir
2025-09-12 11:05   ` Monish Chunara
2025-09-12 13:34     ` Ulf Hansson
2025-09-08  8:19 ` [PATCH v4 02/14] arm64: dts: qcom: lemans: Add SDHC controller and SDC pin configuration Wasim Nazir
2025-09-08  8:19 ` [PATCH v4 03/14] arm64: dts: qcom: lemans-evk: Enable GPI DMA and QUPv3 controllers Wasim Nazir
2025-09-08  8:19 ` [PATCH v4 04/14] arm64: dts: qcom: lemans-evk: Add TCA9534 I/O expander Wasim Nazir
2025-09-11 13:25   ` Bartosz Golaszewski
2025-09-08  8:19 ` [PATCH v4 05/14] dt-bindings: eeprom: at24: Add compatible for Giantec GT24C256C Wasim Nazir
2025-09-08  8:19 ` [PATCH v4 06/14] arm64: dts: qcom: lemans-evk: Add EEPROM and nvmem layout Wasim Nazir
2025-09-11 13:34   ` Bartosz Golaszewski
2025-09-08  8:19 ` [PATCH v4 07/14] arm64: dts: qcom: lemans-evk: Enable PCIe support Wasim Nazir
2025-09-12 12:27   ` Konrad Dybcio
2025-09-15 10:33     ` Sushrut Shree Trivedi [this message]
2025-09-16  6:57       ` Wasim Nazir
2025-09-08  8:19 ` [PATCH v4 08/14] arm64: dts: qcom: lemans-evk: Enable remoteproc subsystems Wasim Nazir
2025-09-08  8:19 ` [PATCH v4 09/14] arm64: dts: qcom: lemans-evk: Enable Iris video codec support Wasim Nazir
2025-09-08  8:20 ` [PATCH v4 10/14] arm64: dts: qcom: lemans-evk: Enable first USB controller in device mode Wasim Nazir
2025-09-08  8:20 ` [PATCH v4 11/14] arm64: dts: qcom: lemans-evk: Enable SDHCI for SD Card Wasim Nazir
2025-09-08  8:20 ` [PATCH v4 12/14] arm64: dts: qcom: lemans-evk: Enable 2.5G Ethernet interface Wasim Nazir
2025-09-08  8:20 ` [PATCH v4 13/14] arm64: dts: qcom: lemans: Add gpr node Wasim Nazir
2025-09-08  8:20 ` [PATCH v4 14/14] arm64: dts: qcom: lemans-evk: Add sound card Wasim Nazir
2025-09-11 13:19 ` (subset) [PATCH v4 00/14] arm64: dts: qcom: lemans-evk: Extend board support for additional peripherals Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8f8df889-3f88-4b9b-a238-16044796d897@quicinc.com \
    --to=quic_sushruts@quicinc.com \
    --cc=andersson@kernel.org \
    --cc=brgl@bgdev.pl \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@oss.qualcomm.com \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=richardcochran@gmail.com \
    --cc=robh@kernel.org \
    --cc=ulf.hansson@linaro.org \
    --cc=wasim.nazir@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox