From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09C3230DD0A; Thu, 26 Mar 2026 07:49:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774511364; cv=none; b=CNpzK+OyzzfVSsNnHVx9gW7dJhocscmn2EznmQnl/nQ9C0OFpHR81v3RB1u+b2kP+LbC6ZHRxrfFuZvYcHcycWkvOs5XPRgDzLulGL6UP+KhErPq9SCJtRHs57pSuZxb7UEmVzYdZzUYt2f8g8fi3nyWb/A03Pbkc1C7k44xv3c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774511364; c=relaxed/simple; bh=FCiZyztzTkX0CyM84RU4JfI9wCheqkaRyooArvKDF5k=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=g6iQG+AvOEI46JeXGXtyDorYAm0amA62UMOvAo/rr5MHgzrhTwMhrav7rE32vOFDSyvL8ybfooRot+h7rx6thm8lTNLpdX0S2kag6MtZSQWbnx0SHDNQ9JM4lFoRbihvTWYPisiu/13b5KpogTHJAmjBjU74swcvlozMH6OJCCI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Kyg27/QD; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Kyg27/QD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 80E2CC116C6; Thu, 26 Mar 2026 07:49:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774511363; bh=FCiZyztzTkX0CyM84RU4JfI9wCheqkaRyooArvKDF5k=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=Kyg27/QDQSurWNTQUTV69RjoLCB1nADLBaU5jNNiFUfeoS2w9KEIvGtKQ2VGC6wn8 8CaHUz/ghxJ8OzmURKtrviSpLY3Ny/VPvCwiev0Y0znncxZoxUpOb7QUPo0+09F+XO JkdLUhR8Uo3xMkbCCovX5QCzsa+1yyN8yRS2LcjVDyn1MfLsNfHr2ex2+T1Kk+fBnz AzNnSbhrewa+jgsoyU0OWLg2lUXdImP8Yd4sCsu16wxIUda9ffVgk1PP3K3D12AjxL 3XbhLl1Ulw2qAeEHt+CLGc2Xuj01ZN7G9MeWXk5I6Oj61aaJPL7fQ4qeYzF/t7u2M2 W3R62aMYD4ZBA== Message-ID: <900dc1a4-66ab-411f-8a32-4c6cf339e8ec@kernel.org> Date: Thu, 26 Mar 2026 08:49:19 +0100 Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/2] dt-bindings: i2c: ls2x-i2c: Add clock- related properties From: Krzysztof Kozlowski To: Hongliang Wang Cc: Binbin Zhou , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, loongarch@lists.linux.dev References: <20260325011852.19079-1-wanghongliang@loongson.cn> <20260325011852.19079-2-wanghongliang@loongson.cn> <20260325-outstanding-weasel-of-fruition-89db37@quoll> <1b5283d8-294c-86de-c3d8-bf205ac24216@loongson.cn> <0d7dfe5b-5e2d-4850-8922-16eb6bd9bcae@kernel.org> Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <0d7dfe5b-5e2d-4850-8922-16eb6bd9bcae@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 26/03/2026 08:02, Krzysztof Kozlowski wrote: > On 26/03/2026 03:12, Hongliang Wang wrote: >> Hi Krzysztof, >> >> Consider the clock framework relies on the device tree, and can only be >> used on >> Loongson 2K platform with dts parameter mechanism, It cannot be used on >> Loongson > > Don't top post or request read receipts. > >> 3A+7A platform with the acpi parameter mechanism. > > And this patch is for ACPI? Then we finish discussion here, because > dt-bindings is not for ACPI. > >> The i2c-ls2x driver is compatible with both Loongson 2K and 3A+7A >> platform, parse >> the same parameters regardless of dts or acpi parameter passing, So >> clock-input >> and clock-div attributes are defined to describe input clock of i2c >> controller and >> divisor of input clock. It can be used on both 2K and 3A+7A platform. > > And you cannot use them in DTS. I need to keep guessing what you want to achieve, because neither your message nor commit text was explicit - if you need properties for ACPI and you want to be sure that DTS does not have them, then you could define them as "foo:false" with a comment why (you always explain WHY you are doing things). We don't have such convention so far, but I think it will be useful when Rob finishes the ABI checker. *Otherwise* minimum would be a comment in the driver that these are not allowed in DTS. Best regards, Krzysztof