Re: [PATCH 4/4] i2c: Remove I2C_CLASS_SPD

Heiner Kallweit
2024-04-17T10:27:34Z

On Wed, Apr 17, 2024 at 10:05 AM Andi Shyti <andi.shyti@kernel.org> wrote:
>
> Hi Heiner and Guenter,
>
> On Mon, Apr 15, 2024 at 10:50:27PM +0200, Heiner Kallweit wrote:
> > Remove this class after all users have been gone.
> >
> > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> > ---
> > include/linux/i2c.h | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/include/linux/i2c.h b/include/linux/i2c.h
> > index 5e6cd43a6..970953737 100644
> > --- a/include/linux/i2c.h
> > +++ b/include/linux/i2c.h
> > @@ -852,7 +852,6 @@ static inline void i2c_mark_adapter_resumed(struct i2c_adapter *adap)
> >
> > /* i2c adapter classes (bitmask) */
> > #define I2C_CLASS_HWMON (1<<0) /* lm_sensors, ... */
> > -#define I2C_CLASS_SPD (1<<7) /* Memory modules */
>
> I missed the fact that we need some synchronization, as I'm
> getting a build failure.
>
> I will revert this and apply it after Guenter has merged his part
> into the mainline.
>
In order to cope with this dependency I proposed in the cover letter
to handle the full series via i2c tree. With Guenter's Ab for the
hwmon patch. Maybe this can still be done as an alternative.
Whatever is easier for both of you.

> Guenter, if you have a spare Post-it, could you please note to CC
> me when this part is sent as a pull request?
>
> Andi
>
> > /* Warn users that the adapter doesn't support classes anymore */
> > #define I2C_CLASS_DEPRECATED (1<<8)
> >
> > --
> > 2.44.0
> >
> >