From: Alexander Sverdlin <alexander.sverdlin@gmail.com>
To: Jean Delvare <jdelvare@suse.de>,
"Zakowski, Piotr" <piotr.zakowski@intel.com>
Cc: andi.shyti@kernel.org, linux-i2c@vger.kernel.org, "Shepon,
Oren" <oren.shepon@intel.com>,
"Kozlowski, Pawel" <pawel.kozlowski@intel.com>,
"Usyskin, Alexander" <alexander.usyskin@intel.com>,
"Radtke, Jakub" <jakub.radtke@intel.com>
Subject: Re: Potential bug in SMBus kernel module
Date: Wed, 14 Feb 2024 19:11:34 +0100 [thread overview]
Message-ID: <91f119a088b8cb54bb43382900bac566a2467f3f.camel@gmail.com> (raw)
In-Reply-To: <20240213120553.7b0ab120@endymion.delvare>
Hi Jean,
On Tue, 2024-02-13 at 12:05 +0100, Jean Delvare wrote:
> Alexander, back when you contributed the code, you said the new command
> was long-time tested, so it's hard to believe it includes the bug
> reported by Piotr. Do you remember which Intel chipset you were using?
> Is the code you submitted exactly what you were using on the hardware,
> or is there a chance that you forgot one change when preparing the
> upstream submission?
from what I can tell, back than it was
"Intel® Xeon® D-1500 product family Integrated PCH Logic".
I'm not sure if it was WILDCATPOINT_SMBUS or LYNXPOINT_SMBUS,
it's nevertheless FEATURES_ICH5, means FEATURE_BLOCK_BUFFER.
Unfortunately, I cannot tell you the details of the tests, but the reason
is that I had to rely on a colleague for this, so I cannot explain
how this went unnoticed back than. Maybe the (incorrect) returned data
was irrelevant for his tests, I can only speculate.
I don't think there was a non-published downstream patch in play.
--
Alexander Sverdlin.
prev parent reply other threads:[~2024-02-14 18:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <SJ0PR11MB5133C098821363F292316A0088482@SJ0PR11MB5133.namprd11.prod.outlook.com>
2024-02-13 11:05 ` Potential bug in SMBus kernel module Jean Delvare
2024-02-13 11:49 ` Alexander Sverdlin
2024-02-14 18:11 ` Alexander Sverdlin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91f119a088b8cb54bb43382900bac566a2467f3f.camel@gmail.com \
--to=alexander.sverdlin@gmail.com \
--cc=alexander.usyskin@intel.com \
--cc=andi.shyti@kernel.org \
--cc=jakub.radtke@intel.com \
--cc=jdelvare@suse.de \
--cc=linux-i2c@vger.kernel.org \
--cc=oren.shepon@intel.com \
--cc=pawel.kozlowski@intel.com \
--cc=piotr.zakowski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox