From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>,
Wolfram Sang <wsa@kernel.org>, Andy Shevchenko <andy@kernel.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: linux-i2c@vger.kernel.org
Subject: Re: [PATCH 2/2] i2c: designware: Use the i2c_mark_adapter_suspended/resumed() helpers
Date: Thu, 24 Feb 2022 15:03:57 +0200 [thread overview]
Message-ID: <929b0821-0a4b-008a-1bf0-22a02831d197@linux.intel.com> (raw)
In-Reply-To: <20220223134839.731138-2-hdegoede@redhat.com>
On 2/23/22 15:48, Hans de Goede wrote:
> Use the i2c_mark_adapter_suspended/resumed() i2c-core helpers and rely
> on the i2c-core's suspended checking instead of using DIY code.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> drivers/i2c/busses/i2c-designware-core.h | 2 --
> drivers/i2c/busses/i2c-designware-master.c | 5 -----
> drivers/i2c/busses/i2c-designware-pcidrv.c | 8 ++------
> drivers/i2c/busses/i2c-designware-platdrv.c | 9 ++-------
> 4 files changed, 4 insertions(+), 20 deletions(-)
>
I think Andy's Reviewed-by for 1/2 holds here too: "Both patches look
good to me and seems like a nice clean up".
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
next prev parent reply other threads:[~2022-02-24 13:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-23 13:48 [PATCH 1/2] i2c: designware: Lock the adapter while setting the suspended flag Hans de Goede
2022-02-23 13:48 ` [PATCH 2/2] i2c: designware: Use the i2c_mark_adapter_suspended/resumed() helpers Hans de Goede
2022-02-24 13:03 ` Jarkko Nikula [this message]
2022-03-01 15:33 ` Wolfram Sang
2022-02-23 14:52 ` [PATCH 1/2] i2c: designware: Lock the adapter while setting the suspended flag Andy Shevchenko
2022-02-23 15:15 ` Hans de Goede
2022-02-24 13:02 ` Jarkko Nikula
2022-03-01 15:32 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=929b0821-0a4b-008a-1bf0-22a02831d197@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=andy@kernel.org \
--cc=hdegoede@redhat.com \
--cc=linux-i2c@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox