From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D01FC4332F for ; Mon, 21 Nov 2022 09:57:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231140AbiKUJ5Q (ORCPT ); Mon, 21 Nov 2022 04:57:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37552 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231156AbiKUJ4y (ORCPT ); Mon, 21 Nov 2022 04:56:54 -0500 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 76E9F2C2 for ; Mon, 21 Nov 2022 01:56:53 -0800 (PST) Received: by mail-wm1-x336.google.com with SMTP id r126-20020a1c4484000000b003cffd336e24so7623910wma.4 for ; Mon, 21 Nov 2022 01:56:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=KV4ztLMcqo35iUBenDly0e7oE30KFyPrfUjUB/4nml8=; b=qGAIRSJg/brYeUvsyEhgzjSgthv9J4NlAZTdDGZE3ltPHyHTUBKuufvD9IOgqR7gED XZDbxN9gEVYJ5ESX05/5hpWG3VP1EWjablmqViOnF5Figgexbs5ZmhupJgMaRN593K+K FTsMWZVUirtfeHBKEwMOV3ruMEPxahUfSWu9eQyunwiv6Y2AyU9Tbrxrg5RmQS+zpFJ2 ALMz8auoeKfkKAM9nxWsrc4Iaq16l+SaVqJubpahEhNmfg39rRiSbo64PR7jKecJrUhW P53+xfQ7CA7bSbFPkxvMGBUU/ZRM2SczqIhhN+L/dtyISAc3lI+WaWXBYiKLRAucFnbh Gcjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KV4ztLMcqo35iUBenDly0e7oE30KFyPrfUjUB/4nml8=; b=BU8jd4xjKFnOxGjWPCzgPwqR6sJmF9nF1zRqrEe2UNqPNbIf8bMxGAJKBx6S659uTV +VuuMBawLsV+yhvBpme/FDdKoWemEBXNcjyn/FphWl5bHhHrONGSTUE0RgnE7lvENFOv mTDs81OngjckYcyBY9bnxGEFxz0XRvPd1/NEkmLUcsB1fGcOWxOSffsxEpKMqk8AXqEg tqDdZMX+PJ44QQOxFAXYF6W1kfooNSWng5zlXyst83mcHwjxicgRffas8gasfMwfljcE wKvqX5NuxU3mPJfMr3kNjhcNcqwmoDl01mRZKBAaG4nd8/RiYm2b3CStEwoMIQtg6sha dzeA== X-Gm-Message-State: ANoB5pnBO2Nx1Kd/dSObAlus/QLPO0ApjKxScXGwjIF5mr4jPdwkU3+A CK3d8+2dHfzzqgUHl0/6lgFwO62u+2t6SQ== X-Google-Smtp-Source: AA0mqf78HuAM8JefAVkxBLHkJ/3gFtd683lcl+iP0S0BL7YXdl+m7GNJV+8qdD2ftDKZbVbK7HdSPA== X-Received: by 2002:a05:600c:1e11:b0:3cf:8d52:a216 with SMTP id ay17-20020a05600c1e1100b003cf8d52a216mr3223702wmb.77.1669024611860; Mon, 21 Nov 2022 01:56:51 -0800 (PST) Received: from [192.168.7.93] (679773502.box.freepro.com. [212.114.21.58]) by smtp.gmail.com with ESMTPSA id l8-20020a5d4bc8000000b002238ea5750csm10734448wrt.72.2022.11.21.01.56.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Nov 2022 01:56:51 -0800 (PST) Message-ID: <929e06bf-84b5-047f-91e9-29876b721cee@linaro.org> Date: Mon, 21 Nov 2022 10:56:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH 431/606] mfd: khadas-mcu: Convert to i2c's .probe_new() Content-Language: en-US To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Angel Iglesias , Lee Jones , Grant Likely , Wolfram Sang , Lee Jones Cc: linux-i2c@vger.kernel.org, kernel@pengutronix.de, =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org References: <20221118224540.619276-1-uwe@kleine-koenig.org> <20221118224540.619276-432-uwe@kleine-koenig.org> Organization: Linaro Developer Services In-Reply-To: <20221118224540.619276-432-uwe@kleine-koenig.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On 18/11/2022 23:42, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König > --- > drivers/mfd/khadas-mcu.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/mfd/khadas-mcu.c b/drivers/mfd/khadas-mcu.c > index f3d418810693..7338cc16f327 100644 > --- a/drivers/mfd/khadas-mcu.c > +++ b/drivers/mfd/khadas-mcu.c > @@ -84,8 +84,7 @@ static struct mfd_cell khadas_mcu_cells[] = { > { .name = "khadas-mcu-user-mem", }, > }; > > -static int khadas_mcu_probe(struct i2c_client *client, > - const struct i2c_device_id *id) > +static int khadas_mcu_probe(struct i2c_client *client) > { > struct device *dev = &client->dev; > struct khadas_mcu *ddata; > @@ -135,7 +134,7 @@ static struct i2c_driver khadas_mcu_driver = { > .name = "khadas-mcu-core", > .of_match_table = of_match_ptr(khadas_mcu_of_match), > }, > - .probe = khadas_mcu_probe, > + .probe_new = khadas_mcu_probe, > }; > module_i2c_driver(khadas_mcu_driver); > Acked-by: Neil Armstrong