Re: [PATCH v3 6/9] soc: qcom: geni-se: Add support to load QUP SE Firmware via Linux subsystem

[Viken Dadhaniya <quic_vdadhani@quicinc.com>]

On 5/3/2025 10:51 PM, Dmitry Baryshkov wrote:
> On Sat, May 03, 2025 at 04:47:52PM +0530, Viken Dadhaniya wrote:
>>
>>
>> On 3/8/2025 11:36 PM, Konrad Dybcio wrote:
>>> On 3.03.2025 1:43 PM, Viken Dadhaniya wrote:
>>>> Load the firmware to QUP SE based on the 'firmware-name' property specified
>>>> in devicetree. Populate Serial engine and base address details in the probe
>>>> function of the protocol driver and pass to firmware load routine.
>>>>
>>>> Skip the firmware loading if the firmware is already loaded in Serial
>>>> Engine's firmware memory area.
>>>>
>>>> Co-developed-by: Mukesh Kumar Savaliya <quic_msavaliy@quicinc.com>
>>>> Signed-off-by: Mukesh Kumar Savaliya <quic_msavaliy@quicinc.com>
>>>> Signed-off-by: Viken Dadhaniya <quic_vdadhani@quicinc.com>
>>>> ---
>>>
>>> [...]
>>>
>>>> +		break;
>>>> +
>>>> +	default:
>>>> +		dev_err(rsc->se->dev, "invalid se mode: %d\n", rsc->mode);
>>>> +		return -EINVAL;
>>>
>>> I wouldn't expect this to ever fail..
>>
>> Yes, that's correct. But including a default case helps handle unexpected or
>> invalid input gracefully.
>>
>> Please let me know if you would like me to remove it.
> 
> If you are asking for additional comments, please refrain from sending
> the next iteration until you actally resolve all the open questions.
> 

Sure, I will take care of it in future patches.