From: Heiner Kallweit <hkallweit1@gmail.com>
To: "Thomas Weißschuh" <linux@weissschuh.net>,
"Andi Shyti" <andi.shyti@kernel.org>,
"Jean Delvare" <jdelvare@suse.com>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
Guenter Roeck <linux@roeck-us.net>,
Wolfram Sang <wsa+renesas@sang-engineering.com>
Subject: Re: [PATCH v3 1/2] i2c: smbus: remove i801 assumptions from SPD probing
Date: Fri, 12 Jul 2024 12:21:07 +0200 [thread overview]
Message-ID: <97cf818b-f72c-4461-afec-307ac98d2bf9@gmail.com> (raw)
In-Reply-To: <20240709-piix4-spd-v3-1-9d1daa204983@weissschuh.net>
On 09.07.2024 19:35, Thomas Weißschuh wrote:
> The check and warning are very specific to the SPD usage of the i801
> driver. That was fine as long as i801 was the only caller of
> i2c_register_spd(). Now that piix4 will be added as another user of that
> function, the check and warning are not accurate anymore.
> Instead of introducing a more complicated calling protocol only to print
> a warning, drop the warning.
> Even in cases where not all slots can be probed,
> then at least probe the 8 slots that can be.
>
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> ---
> drivers/i2c/i2c-smbus.c | 15 ++++-----------
> 1 file changed, 4 insertions(+), 11 deletions(-)
>
Reviewed-by: Heiner Kallweit <hkallweit1@gmail.com>
next prev parent reply other threads:[~2024-07-12 10:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-09 17:35 [PATCH v3 0/2] i2c: smbus cleanups and SPD support for piix4 Thomas Weißschuh
2024-07-09 17:35 ` [PATCH v3 1/2] i2c: smbus: remove i801 assumptions from SPD probing Thomas Weißschuh
2024-07-09 22:33 ` Andi Shyti
2024-07-12 10:21 ` Heiner Kallweit [this message]
2024-07-09 17:35 ` [PATCH v3 2/2] i2c: piix4: Register SPDs Thomas Weißschuh
2024-07-12 12:53 ` Wolfram Sang
2024-07-16 17:46 ` Andi Shyti
2024-07-16 17:50 ` Thomas Weißschuh
2024-07-16 18:05 ` Andi Shyti
2024-07-12 0:02 ` [PATCH v3 0/2] i2c: smbus cleanups and SPD support for piix4 Andi Shyti
2024-07-12 6:39 ` Wolfram Sang
2024-07-16 18:27 ` Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97cf818b-f72c-4461-afec-307ac98d2bf9@gmail.com \
--to=hkallweit1@gmail.com \
--cc=andi.shyti@kernel.org \
--cc=jdelvare@suse.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=linux@weissschuh.net \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox