From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 33183175A84; Mon, 29 Jun 2026 06:34:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782714888; cv=none; b=r+la9ZGGGlGvlS3ZSOI3ZWGlPANNv1bwv54qE9QURuv1su81xXL+CJkTLBZnXaUoqR0kedSOyeZ69jdl7nfhaCsftmbQBSNrj67xH0E9rEtSZ+ox4ltIsyP+PZDDscnwkOPEZqG3Sz88qBy8YZQIX4Upup32ehW1VyQIkBHvQMk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782714888; c=relaxed/simple; bh=ZrQ4j00CVYCu5fa/F72RKabns3YmDj/0lzrCvgxaLtk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NPfJkFHDjUVzFw6kXSW9sDRzzdiOHB2ia5+/i/lItT0Za70Wd2VLYTep0qC8vk+AnaoAgqaImltkA97C3ciRxqxtH1s3IDTIHno4HV/aVtvoUoh7ivqmgF0/osm5ksyQ3K7E6BpERkSdUw5kE99tvyHQ8U+PbdMBfXiLmmqjdUk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Czgy0J8v; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Czgy0J8v" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 335001F000E9; Mon, 29 Jun 2026 06:34:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782714886; bh=JpJlk2AiNaZR6zqqG48KyNL3rUCic2qAarJLwpuN64k=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=Czgy0J8vrQXTvJ7eCeAkrZamPREUFGHgqaSsfEgI3c/YrOiTuCNjl1bUT+P0fOxDM DLNSup5yJ1RanlAO3z+lDJFw8HbE9Mpj4MktJwpU2k5deQku07InocatKqU++LA2JK 7cjxhQOUrUOrwoUIv7VXLgVDqFATF8ocxA1widgQjLNzi4lqv/LUvatrjwMd35rSD9 QZND+JFrKRlGxDVP/X/Fwt73jf3kgBk3nfBeWlkzyc638mdx5Sptzgxh7/M5c2mxwO l+wrYA45tY4ZQg6d+x6jf/LOk2rN5ciFsm6CaXHGAq07O05TIBnMx9xUs0VrLqYrwk j7XD7pPnOD/Zw== Message-ID: <981cfe8d-d438-43e0-a2ff-13f3006f82e0@kernel.org> Date: Mon, 29 Jun 2026 08:34:31 +0200 Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 2/3] i2c: qcom-slave: Add driver for Qualcomm I2C slave controller To: Viken Dadhaniya , Mukesh Kumar Savaliya , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260628-i2c-qcom-slave-v1-0-8b0a5c01f9f6@oss.qualcomm.com> <20260628-i2c-qcom-slave-v1-2-8b0a5c01f9f6@oss.qualcomm.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGPBBMBCgA5AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJp2mE8AAoJEBuTQ307QWKbeaIP /ihHTkTW4KsN/DQ945JJbyu5tI0J80Wue7QyyLPglyKfhgb5cLLNPpOC8cCIJsc7+W3i2P38 s2c1cOH6CYGE7E9ur3Vfme8NW2S2I/Z8VC7bZnzyS23wT17LrsdS/qCpx4o8U+pt/xdXDKph EGRYrIEmMpUWvyYzyYKGIe25FtaayIIKpq8eZYyFcp2f/sG5IkOW5uZzHPMPdcm87jU7fyuQ rAU2vx9r+ulUfQ/q9Z2roC/ode3l7t2pN7BCBCsUDp6JCrUyZrtT1e7EbA0ZRP3aOBNk2P2E DQOgJGjGdO5Yx2Y9LFtltu6JbsBJHi1syGRX3AtQYOMc4Y1WGoeZJmMlvKj2ZqqXNkcWi2DS IQEWB0uW6CqFsBBIMGDa+6OzdaVO/uAVXWDWml02Men3CILdI1MbVjoh8ECqYUY7OQ+JJvNN vnliuq5WM3Ghd3jg/LZZrxXjdIginRHFQCjIJYLKpLZWm1/iDFedcfzqRNYmTtqscdCNHW41 oT3Z7BmO9xwdjuwBS6nmS6JJwkbf5Ot2QR4pB/DRU7ZwjT1qHe+9r9gF32wXVQatHNGK/VVu sfwOnkdxCWkp/qb2gdQRmZh+SedStWshigH6sNfuHBloF/q+hjMRc8b2m326OZdrbSHwY1Sz vti8Hn7n8NjdHO9LKB7BIdjkA9DA5WsqOuVCzsFNBFVDXDQBEADNkrQYSREUL4D3Gws46JEo Z9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLueMNsWLJBv BaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6eiOMheesVS 5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wAGldWsRxb f3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA6z6lBZn0 WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9YegxWKvX XHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt91pFzBSO IpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gUBLHFTg2h YnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/JoFzZ4B0 p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu4vXVFBYI GmpyNPYzRm0QPwARAQABwsF2BBgBCgAgAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmna YUkACgkQG5NDfTtBYptX+BAApg32CkxwNucNEi8WfWA8oKkW0y8YDuY6ORMo9FWNGiT/OTy0 vyJrLocrpn86zwfjVp+eCrssPYh8eqJfnWqmYv6ACQtHPYzPZQ3mSo8H97Z01oUxITzCxpXm ZkLgPIqtDPcC2E3dPM/fVxcyowM8XsaMA9wcsaUYrta8toOq2b9tKcjleKMfMrm0gQ9u7wUc QbLkwj6TCLOwucb07GXzLTNF9PZmaDUpKAZjMjmrW+le+SFvQbhamx0rxLWPR0NWntXpbCn+ +ACch03p/JyTBVktxFsFyCt7pTPE1kEaeuXBTe/a2D9iQvRxRW19LvuO2e59/u1wYUiH/orz wbIC2S4dBsPAPihL3ztOU1yE86GPyQtSE0kU+/7snnLt4QGi6PChf3t5gnNjAzjUUovO8rgI c+5yN5heq5loYHgK6OQ9OlHzsPHO9e9MOQcKlFycs1pyijFGzDwdNUm/SchK8iWT2QApTx4A K9bCVaboTA2T77QYkRcRJYSsO1alGX0ome/hMLD1daXlkrNUp1HWa3K4iytLRXjCSIorWiGs n+q3krnpXu3TFkA8qtOFZMdnIiFuiq1yLT8hptsV5xh1TA2nsVvSYiaCr3q4s4BKjS/KrLDb qoxzw8ISjdUp4pA85vb6YLCmb39NgidD+7PmAr65lBNveIFynTgsja1rRQ4= In-Reply-To: <20260628-i2c-qcom-slave-v1-2-8b0a5c01f9f6@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 28/06/2026 16:39, Viken Dadhaniya wrote: > + slave->adap.owner = THIS_MODULE; > + slave->adap.algo = &qcom_i2c_slave_algo; > + slave->adap.dev.parent = dev; > + slave->adap.dev.of_node = dev->of_node; > + strscpy(slave->adap.name, "qcom-i2c-slave", sizeof(slave->adap.name)); > + > + i2c_set_adapdata(&slave->adap, slave); > + platform_set_drvdata(pdev, slave); > + > + ret = i2c_add_adapter(&slave->adap); > + if (ret) { > + dev_err(dev, "i2c_add_adapter failed: %d\n", ret); > + icc_disable(slave->icc_path); > + return ret; > + } > + > + dev_info(dev, "Qualcomm I2C slave probed at address 0x%x\n", addr); NAK, as reviewed many times. Drivers must be silent and you don't even print any useful information, becausr address is fixed based on DT. > + return 0; > +} > + > +/** > + * qcom_i2c_slave_remove - remove the Qualcomm I2C slave controller > + * @pdev: platform device > + * > + * Unregisters the I2C adapter and disables the interconnect path. > + * Controller clocks are disabled automatically by the devm framework. > + */ Really, what sort of coding style is that? Since when Linux kernel writes kerneldoc for standard driver hooks? > +static void qcom_i2c_slave_remove(struct platform_device *pdev) > +{ > + struct qcom_i2c_slave *slave = platform_get_drvdata(pdev); > + > + i2c_del_adapter(&slave->adap); > + icc_disable(slave->icc_path); > + /* clocks are disabled automatically by devm */ > +} > + > +/** > + * qcom_i2c_slave_suspend - suspend the controller > + * @dev: device associated with the controller > + * > + * Disables the interrupt, releases the interconnect bandwidth vote, and > + * disables the controller clocks to allow the system to enter a low-power > + * state. > + * > + * Return: 0 always. > + */ Please don't send us downstream code or LLM generated slop. There is no single driver written that way. Best regards, Krzysztof