public inbox for linux-i2c@vger.kernel.org
 help / color / mirror / Atom feed
From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Jan Dabros <jsd@semihalf.com>,
	linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
	andriy.shevchenko@linux.intel.com
Cc: wsa@kernel.org, upstream@semihalf.com
Subject: Re: [PATCH v2 -next] i2c: designware: Remove code duplication
Date: Fri, 11 Mar 2022 10:24:01 +0200	[thread overview]
Message-ID: <99e859a3-5a8e-8dc2-5a04-0a63f69173a6@linux.intel.com> (raw)
In-Reply-To: <20220310220932.140973-1-jsd@semihalf.com>

On 3/11/22 00:09, Jan Dabros wrote:
> Simplify code by moving common part to one function.
> 
> Signed-off-by: Jan Dabros <jsd@semihalf.com>
> Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> v1->v2:
> * Add kudos for Andy who suggested this change
> * Get rid of extra function and move common code to psp_send_i2c_req
> * Update commit message and commit title
>    (was "i2c:designware: Add helper to remove redundancy")
>   drivers/i2c/busses/i2c-designware-amdpsp.c | 35 ++++++++++------------
>   1 file changed, 15 insertions(+), 20 deletions(-)
> 
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>

  reply	other threads:[~2022-03-11  8:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-10 22:09 [PATCH v2 -next] i2c: designware: Remove code duplication Jan Dabros
2022-03-11  8:24 ` Jarkko Nikula [this message]
2022-03-11 17:01 ` Andy Shevchenko
2022-03-11 20:51 ` Wolfram Sang
2022-03-14  8:56   ` Jan Dąbroś
2022-03-14  9:03   ` Jarkko Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=99e859a3-5a8e-8dc2-5a04-0a63f69173a6@linux.intel.com \
    --to=jarkko.nikula@linux.intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=jsd@semihalf.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=upstream@semihalf.com \
    --cc=wsa@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox