From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A548C5B5C1 for ; Fri, 12 Jan 2024 08:13:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="WcDIPfQt" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1705047208; x=1736583208; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=3q7iAJWz8c1xvGzEpfQaQfH3fgSvOqIYaD9mOIjx4J4=; b=WcDIPfQtM2QAjDgvsBMdx+lTpnKDNyHCJO3ksrioJVPlZMPIh/E4IL8q qAQ5Szg2wPRg7Ew5Z5uJYT9reoOhfkAwt/JB0uUNuVZNGVNTM2vNB4+Wl 0W+kuwxkUJq6+V4W7ESZ1aGdxy8diqTnCuD6gUoA1ZE7vg00t4QOWACaH ZzexDm8TfS5ukDC/DJwA9O8tLBQKYnDtysJQlufyP+xgmRzsXeMYLDqHS ejunbvkrEEx7iWZNk6nMZVXmkoOInQYCR+UjIkxfqLaUG6XVSs3bqE4f9 5IKMKNoMyMFORfL7Zv1/o1lbzyNf8Xp8PRGaqHyfKA7gNqyC+wYA1EOgT w==; X-IronPort-AV: E=McAfee;i="6600,9927,10950"; a="5842905" X-IronPort-AV: E=Sophos;i="6.04,188,1695711600"; d="scan'208";a="5842905" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2024 00:13:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10950"; a="732511322" X-IronPort-AV: E=Sophos;i="6.04,188,1695711600"; d="scan'208";a="732511322" Received: from unknown (HELO [10.237.72.158]) ([10.237.72.158]) by orsmga003.jf.intel.com with ESMTP; 12 Jan 2024 00:13:24 -0800 Message-ID: <9bb96130-d662-4904-9e4b-6a823b51a990@linux.intel.com> Date: Fri, 12 Jan 2024 10:13:23 +0200 Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] i2c: designware: Revert recent changes to i2c_dw_probe_lock_support() Content-Language: en-US To: Kim Phillips , linux-i2c@vger.kernel.org Cc: Wolfram Sang , Andy Shevchenko , Mika Westerberg , Jan Dabros , Andi Shyti , Borislav Petkov , V Narasimhan References: <20240111125658.921083-1-jarkko.nikula@linux.intel.com> From: Jarkko Nikula In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi On 1/11/24 19:56, Kim Phillips wrote: >> [    6.245173] i2c_designware AMDI0010:00: Unknown Synopsys component >> type: 0xffffffff This has puzzled me all the time since I'm unable to see which one of Andy's patches could cause it. However controller is clearly powered down since DW_IC_COMP_TYPE register reads 0xffffffff. That I'd call as a regression one. Second regression is the Oops and I was speculating if commit bd466a892612 ("i2c: designware: Fix PM calls order in dw_i2c_plat_probe()") can cause it. > > Hold on, I'm testing this on top of next-20240111 and still seeing the > splat... > Btw, does this reproduce always? Can we be mislead if it happens somewhat randomly? Happens to boot once we revert some commits and then at another Andy's nearby commit does not and we make the wrong conclusion? Does bisecting between v6.7-rc1 and next-20240111 lead anywhere?