From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Mukesh Kumar Savaliya <quic_msavaliy@quicinc.com>,
konrad.dybcio@linaro.org, andersson@kernel.org,
andi.shyti@kernel.org, linux-arm-msm@vger.kernel.org,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-i2c@vger.kernel.org
Cc: quic_vdadhani@quicinc.com
Subject: Re: [PATCH v1 0/4] Enable shared SE support over I2C
Date: Thu, 29 Aug 2024 10:56:24 +0100 [thread overview]
Message-ID: <9eed39f3-baf3-41cb-bd19-361d76207b09@linaro.org> (raw)
In-Reply-To: <20240829092418.2863659-1-quic_msavaliy@quicinc.com>
On 29/08/2024 10:24, Mukesh Kumar Savaliya wrote:
> This Series adds support to share QUP based I2C SE between subsystems.
> Each subsystem should have its own GPII which interacts between SE and
> GSI DMA HW engine.
What is SE ?
GPII - general purpose interrupt ... ?
You have too many acronyms here, which makes reading and understanding
your cover letter a bit hard.
Please define at least the term SE in your cover letter and in your patch.
In the patch you use the term TRE which without diving into the code I
vaguely remember is a register..
- GPII
- GSI
- SE
- TRE
Need to be defined to make what's going on in this series more "grokable".
A cover letter should assume a reviewer is familiar with the basics of a
system - no need to define what I2C is but, similarly shouldn't assume a
reviewer is numerate in the taxonomy of vendor specific architecture
e.g. whats SE ?
---
bod
next prev parent reply other threads:[~2024-08-29 9:56 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-29 9:24 [PATCH v1 0/4] Enable shared SE support over I2C Mukesh Kumar Savaliya
2024-08-29 9:24 ` [PATCH v1 1/4] dt-bindindgs: i2c: qcom,i2c-geni: Document shared flag Mukesh Kumar Savaliya
2024-08-29 9:58 ` Bryan O'Donoghue
2024-08-29 10:01 ` Bryan O'Donoghue
2024-09-04 18:26 ` Mukesh Kumar Savaliya
2024-09-04 18:37 ` Mukesh Kumar Savaliya
2024-08-30 8:11 ` Krzysztof Kozlowski
2024-09-04 18:12 ` Mukesh Kumar Savaliya
2024-09-04 18:20 ` Krzysztof Kozlowski
2024-09-05 5:43 ` Mukesh Kumar Savaliya
2024-09-05 6:21 ` Krzysztof Kozlowski
2024-09-05 11:17 ` Mukesh Kumar Savaliya
2024-08-29 9:24 ` [PATCH v1 2/4] dma: gpi: Add Lock and Unlock TRE support to access SE exclusively Mukesh Kumar Savaliya
2024-08-29 10:05 ` Bryan O'Donoghue
2024-09-04 18:23 ` Mukesh Kumar Savaliya
2024-08-29 9:24 ` [PATCH v1 3/4] soc: qcom: geni-se: Export function geni_se_clks_off() Mukesh Kumar Savaliya
2024-08-29 10:19 ` Bryan O'Donoghue
2024-09-04 18:12 ` Mukesh Kumar Savaliya
2024-08-29 9:24 ` [PATCH v1 4/4] i2c: i2c-qcom-geni: Enable i2c controller sharing between two subsystems Mukesh Kumar Savaliya
2024-08-29 9:56 ` Bryan O'Donoghue [this message]
2024-09-04 18:21 ` [PATCH v1 0/4] Enable shared SE support over I2C Mukesh Kumar Savaliya
2024-08-29 10:10 ` Bryan O'Donoghue
2024-09-04 18:08 ` Mukesh Kumar Savaliya
2024-08-29 17:01 ` Vinod Koul
2024-08-30 7:47 ` neil.armstrong
2024-09-04 18:07 ` Mukesh Kumar Savaliya
2024-09-05 7:09 ` neil.armstrong
2024-09-05 9:28 ` Mukesh Kumar Savaliya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9eed39f3-baf3-41cb-bd19-361d76207b09@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=andersson@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_msavaliy@quicinc.com \
--cc=quic_vdadhani@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).