From: Timur Tabi <timur.tabi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Kumar Gala <galak-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
Cc: Ben Dooks <ben-i2c-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>,
Xulei <B33228-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] I2C: Add support for 64bit system.
Date: Tue, 15 Mar 2011 10:56:07 -0500 [thread overview]
Message-ID: <AANLkTim0_ttjDPJvx71B-=Ze5dRTrKXfpavx7gxvYr5p@mail.gmail.com> (raw)
In-Reply-To: <D9BF0938-44B1-4BB8-BF3C-0A9CB44B9CC5-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
On Tue, Mar 15, 2011 at 10:44 AM, Kumar Gala <galak-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org> wrote:
>
> On Dec 20, 2010, at 8:59 AM, Ben Dooks wrote:
>
>> On Mon, Dec 20, 2010 at 03:37:34PM +0800, Xulei wrote:
>>> Currently I2C_MPC supports 32bit system only, then this
>>> modification makes it support 32bit and 64bit system both.
>>>
>>> Signed-off-by: Xulei <B33228-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
>>
>> This been build or run tested?
>
> Yes, Any issues with me applying this via the powerpc.git tree?
I'm concerned about the fact that we have to have two defines to
declare code that is 32-bit and 64-bit clean. Technically speaking,
all drivers should work in both environments. It seems silly to have
"PPC32 || PPC64" for everything. Isn't there a generic "PPC" config
option that covers this?
--
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2011-03-15 15:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-20 7:37 [PATCH] I2C: Add support for 64bit system Xulei
[not found] ` <1292830654-7056-1-git-send-email-B33228-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2010-12-20 14:59 ` Ben Dooks
[not found] ` <20101220145954.GA1126-SMNkleLxa3Z6Wcw2j4pizdi2O/JbrIOy@public.gmane.org>
2010-12-21 7:32 ` xulei
2011-03-15 15:44 ` Kumar Gala
[not found] ` <D9BF0938-44B1-4BB8-BF3C-0A9CB44B9CC5-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
2011-03-15 15:56 ` Timur Tabi [this message]
[not found] ` <AANLkTim0_ttjDPJvx71B-=Ze5dRTrKXfpavx7gxvYr5p-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-03-15 16:00 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTim0_ttjDPJvx71B-=Ze5dRTrKXfpavx7gxvYr5p@mail.gmail.com' \
--to=timur.tabi-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=B33228-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=ben-i2c-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=galak-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).