Re: [PATCH] [ARM] tegra: Add i2c support

[Colin Cross <ccross-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>]

On Thu, Sep 2, 2010 at 2:54 PM, Colin Cross <ccross-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> wrote:
> On Tue, Aug 10, 2010 at 7:57 AM, Mike Rapoport <mike-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org> wrote:
>> Hi Colin,
>> Two more comments.
>>
>> Colin Cross wrote:
>>>
>>> From: Colin Cross <ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org>
>>>
>>> CC: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>>> Signed-off-by: Colin Cross <ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org>
>>> ---
>>>  drivers/i2c/busses/Kconfig     |    7 +
>>>  drivers/i2c/busses/Makefile    |    1 +
>>>  drivers/i2c/busses/i2c-tegra.c |  665
>>> ++++++++++++++++++++++++++++++++++++++++
>>>  include/linux/i2c-tegra.h      |   25 ++
>>
>> This should probably go to arch/arm/mach-tegra/include/mach/ to minimize the
>> pollution in include/linux
> The existing standard seems to be to use include/linux
>
>>>  4 files changed, 698 insertions(+), 0 deletions(-)
>>>  create mode 100644 drivers/i2c/busses/i2c-tegra.c
>>>  create mode 100644 include/linux/i2c-tegra.h
>>>
>>
>> [ snip ]
>>
>>> +
>>> +static int __init tegra_i2c_init_driver(void)
>>> +{
>>> +       return platform_driver_register(&tegra_i2c_driver);
>>> +}
>>> +module_init(tegra_i2c_init_driver);
>>
>> subsys_initcall would be better here.
> This can be compiled as a module, subsys_initcall would break that.
I stand corrected - subsys_initcall becomes module_init if it's
compiled as a module.  I'll fix it.