From: "Håvard Skinnemoen" <hskinnemoen-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Ben Dooks <ben-i2c-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>
Cc: Eran Duchan <pavius-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Grant Likely
<grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
Subject: Re: [PATCH] i2c: Adding the i2c-bit-platform bus
Date: Wed, 11 May 2011 10:10:33 -0700 [thread overview]
Message-ID: <BANLkTi=OFhMwRRnYiHZyDBKB1QiG-0T6Tw@mail.gmail.com> (raw)
In-Reply-To: <20110510223556.GD634-RazCHl0VsYgkUSuvROHNpA@public.gmane.org>
On Tue, May 10, 2011 at 3:35 PM, Ben Dooks <ben-i2c-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org> wrote:
> On Sat, May 07, 2011 at 02:53:05PM +0300, Eran Duchan wrote:
>> +static int __devinit i2c_bit_platform_probe(struct platform_device *pdev)
>> +{
>> + struct i2c_algo_bit_data *bit_data;
>> + struct i2c_adapter *adap;
>> + int ret;
>> +
>> + if (pdev->dev.platform_data == NULL)
>> + ret = -ENXIO;
>
> minor point, this will probably not get shown by the bus layer.
> Not sure what's best here, some people don't like -ENOENT here.
I think ENXIO is fine though. Many drivers use it to indicate "I don't
have enough information to initialize this device".
Havard
prev parent reply other threads:[~2011-05-11 17:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-07 11:53 [PATCH] i2c: Adding the i2c-bit-platform bus Eran Duchan
[not found] ` <BANLkTi=JtYdJr+0Dv32r-sCTgE-Eom2CJQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-05-07 15:47 ` Eran Duchan
2011-05-10 22:35 ` Ben Dooks
[not found] ` <20110510223556.GD634-RazCHl0VsYgkUSuvROHNpA@public.gmane.org>
2011-05-11 17:10 ` Håvard Skinnemoen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=OFhMwRRnYiHZyDBKB1QiG-0T6Tw@mail.gmail.com' \
--to=hskinnemoen-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=ben-i2c-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=pavius-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).