From: Manuel Lauss <manuel.lauss-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
To: Ben Dooks <ben-i2c-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>
Cc: Linux-I2C <linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] i2c-au1550: increase timeout waiting for transactions to finish
Date: Thu, 16 Jun 2011 08:00:47 +0200 [thread overview]
Message-ID: <BANLkTi=T7C07ybWqXLmuYPqpjHtohewKrw@mail.gmail.com> (raw)
In-Reply-To: <20110615214009.GJ15795-SMNkleLxa3Z6Wcw2j4pizdi2O/JbrIOy@public.gmane.org>
On Wed, Jun 15, 2011 at 11:40 PM, Ben Dooks <ben-i2c-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org> wrote:
> On Sun, Jun 12, 2011 at 02:31:27PM +0200, Manuel Lauss wrote:
>> Wait a bit longer for the I2C master transaction to finish.
>> With this change the WM8731 codec on the DB1300 board is now
>> reliably initialized.
>>
>> Tested on Db1200 and Db1300.
>>
>> Signed-off-by: Manuel Lauss <manuel.lauss-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
>
> If no-one else can think of a better fix, then this can go into -rc.
>
> Is there no register that could be read to find out if the system is
> busy?
That's what the function in the patch does: polls for the "master done"
bit to be set. The timeout around it is just too short for some systems.
Next merge window is fine for this too. For the current in-tree users this
driver actually works fine.
Manuel Lauss
prev parent reply other threads:[~2011-06-16 6:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-12 12:31 [PATCH] i2c-au1550: increase timeout waiting for transactions to finish Manuel Lauss
[not found] ` <1307881887-12676-1-git-send-email-manuel.lauss-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
2011-06-15 21:40 ` Ben Dooks
[not found] ` <20110615214009.GJ15795-SMNkleLxa3Z6Wcw2j4pizdi2O/JbrIOy@public.gmane.org>
2011-06-16 6:00 ` Manuel Lauss [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=T7C07ybWqXLmuYPqpjHtohewKrw@mail.gmail.com' \
--to=manuel.lauss-gm/ye1e23mwn+bqq9rbeug@public.gmane.org \
--cc=ben-i2c-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).