linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sonny Rao <sonnyrao-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
To: Mark Brown
	<broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
Cc: Alan Stern
	<stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org>,
	Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>,
	"Rafael J. Wysocki" <rjw-KKrjLPT3xs0@public.gmane.org>,
	linux-pm-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	"Ben Dooks (embedded platforms)"
	<ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>
Subject: Re: [linux-pm] [RFC][PATCH] Enable async suspend/resume of i2c devices
Date: Wed, 6 Apr 2011 16:08:32 -0700	[thread overview]
Message-ID: <BANLkTikApnXBtP7c=QLEvM9ye=_YZiSSqw@mail.gmail.com> (raw)
In-Reply-To: <20110406223123.GA5297-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>

On Wed, Apr 6, 2011 at 3:31 PM, Mark Brown
<broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org> wrote:
> On Wed, Apr 06, 2011 at 10:49:17AM -0400, Alan Stern wrote:
>
>> Neither is the case.  For these subsystems, the PM dependencies _are_
>> known.
>
> ...
>
>> Now, I have no idea what the situation is with regard to I2C...
>
> You definitely don't know *anything* about the relationships for I2C,
> especially in embedded systems.
>

Would it be okay to enable this on a per-device basis where it is
known to be safe?

I started out doing it like this,  but I didn't like the way the patch looked
because it ended up having to call this function twice -- once on the i2c
master device and once on it's client devices (and actually a third time
because it had another struct dev for the industrial IO device).  So,
that seemed pretty ugly.

Also, it didn't seem to match the usage of device_enable_async_suspend()
in other parts of the kernel where it was used on whole subsystems.

Sonny

  parent reply	other threads:[~2011-04-06 23:08 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-05  3:47 [RFC][PATCH] Enable async suspend/resume of i2c devices Sonny Rao
     [not found] ` <BANLkTik7i0VQpJb+enUd9c4-XvZQ1S57fQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-04-06  5:23   ` Mark Brown
     [not found]     ` <20110406052335.GA25578-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2011-04-06  6:51       ` Sonny Rao
2011-04-06  7:52     ` Jean Delvare
     [not found]       ` <20110406095240.410b4e7e-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2011-04-06  8:16         ` Sonny Rao
     [not found]           ` <BANLkTimaRdRNOYM43AhjrU70o=GL0Q-D-A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-04-06  8:23             ` Jean Delvare
2011-04-06 14:49         ` [linux-pm] " Alan Stern
     [not found]           ` <Pine.LNX.4.44L0.1104061043220.1907-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2011-04-06 22:31             ` Mark Brown
     [not found]               ` <20110406223123.GA5297-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2011-04-06 23:08                 ` Sonny Rao [this message]
     [not found]                   ` <BANLkTikApnXBtP7c=QLEvM9ye=_YZiSSqw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-04-07  5:22                     ` Rafael J. Wysocki
     [not found]                       ` <201104070722.44771.rjw-KKrjLPT3xs0@public.gmane.org>
2011-04-07  6:45                         ` Sonny Rao
2011-04-07  7:55                 ` Jean Delvare
     [not found]                   ` <20110407095513.4c0b708e-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2011-04-07  8:00                     ` Mark Brown
     [not found]                       ` <20110407080042.GF14519-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2011-04-07  8:25                         ` Jean Delvare
     [not found]                           ` <20110407102544.4c34dfeb-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2011-04-07 14:34                             ` Alan Stern
2011-04-07  8:19                     ` Sonny Rao
     [not found]                       ` <BANLkTikDc6QhtK6F5VTX4iCkT0CAiXvztg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-04-07  8:33                         ` Jean Delvare
2011-04-07  5:18         ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='BANLkTikApnXBtP7c=QLEvM9ye=_YZiSSqw@mail.gmail.com' \
    --to=sonnyrao-f7+t8e8rja9g9huczpvpmw@public.gmane.org \
    --cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
    --cc=broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org \
    --cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-pm-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=rjw-KKrjLPT3xs0@public.gmane.org \
    --cc=stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).