From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: [PATCH] gpio: pca953x: change driver name to be unique Date: Thu, 30 Jun 2011 08:47:55 -0600 Message-ID: References: <1309440959-18692-1-git-send-email-w.sang@pengutronix.de> <20110630161101.4bee9b19@endymion.delvare> <20110630141823.GF1997@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20110630141823.GF1997-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Wolfram Sang Cc: Jean Delvare , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-i2c@vger.kernel.org On Thu, Jun 30, 2011 at 8:18 AM, Wolfram Sang w= rote: > On Thu, Jun 30, 2011 at 04:11:01PM +0200, Jean Delvare wrote: >> On Thu, 30 Jun 2011 15:35:59 +0200, Wolfram Sang wrote: >> > This driver handles the variants pca9534-pca9539, so it chose the = name >> > "pca953x". However, there is a led driver which decided on the sam= e >> > name. As a result, those two can't be loaded at the same time. Add= a >> > subsystem prefix to make the driver name unique. Device matching w= ill >> > not suffer, because both are I2C drivers which match using a >> > i2c_device_id-table which is not altered. >> > >> > Signed-off-by: Wolfram Sang >> > --- >> > =A0drivers/gpio/pca953x.c | =A0 =A02 +- >> > =A01 files changed, 1 insertions(+), 1 deletions(-) >> > >> > diff --git a/drivers/gpio/pca953x.c b/drivers/gpio/pca953x.c >> > index 0451d7a..b30dd0b 100644 >> > --- a/drivers/gpio/pca953x.c >> > +++ b/drivers/gpio/pca953x.c >> > @@ -742,7 +742,7 @@ static int pca953x_remove(struct i2c_client *c= lient) >> > >> > =A0static struct i2c_driver pca953x_driver =3D { >> > =A0 =A0 .driver =3D { >> > - =A0 =A0 =A0 =A0 =A0 .name =A0 =3D "pca953x", >> > + =A0 =A0 =A0 =A0 =A0 .name =A0 =3D "gpio-pca953x", >> > =A0 =A0 }, >> > =A0 =A0 .probe =A0 =A0 =A0 =A0 =A0=3D pca953x_probe, >> > =A0 =A0 .remove =A0 =A0 =A0 =A0 =3D pca953x_remove, >> >> With the proposed change to the leds-pca9532 driver, you could leave >> this one alone, for the sake of simplicity and consistency with the >> pca953x, pcf857x and max732x gpio drivers. >> >> But I am not objecting to this change, if you like it. > > I am fine with your suggestion. All right, I'll ignore this patch then. g.