* [PATCH] i2c-eg20t: Do not print error message if no ACK is received
@ 2011-06-28 9:43 Alexander Stein
2011-06-28 10:18 ` Christian Gmeiner
[not found] ` <1309254219-18875-1-git-send-email-alexander.stein-93q1YBGzJSMe9JSWTWOYM3xStJ4P+DSV@public.gmane.org>
0 siblings, 2 replies; 3+ messages in thread
From: Alexander Stein @ 2011-06-28 9:43 UTC (permalink / raw)
To: Jean Delvare, Ben Dooks
Cc: Tomoya MORINAGA, linux-i2c-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Alexander Stein
Doing so would spam the kernel log for each i2cdetect run and
device probe.
Signed-off-by: Alexander Stein <alexander.stein-93q1YBGzJSMe9JSWTWOYM3xStJ4P+DSV@public.gmane.org>
---
drivers/i2c/busses/i2c-eg20t.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/i2c/busses/i2c-eg20t.c b/drivers/i2c/busses/i2c-eg20t.c
index 8abfa4a..97110f7 100644
--- a/drivers/i2c/busses/i2c-eg20t.c
+++ b/drivers/i2c/busses/i2c-eg20t.c
@@ -345,7 +345,7 @@ static s32 pch_i2c_getack(struct i2c_algo_pch_data *adap)
reg_val = ioread32(p + PCH_I2CSR) & PCH_GETACK;
if (reg_val != 0) {
- pch_err(adap, "return%d\n", -EPROTO);
+ pch_dbg(adap, "return%d\n", -EPROTO);
return -EPROTO;
}
--
1.7.3.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] i2c-eg20t: Do not print error message if no ACK is received
2011-06-28 9:43 [PATCH] i2c-eg20t: Do not print error message if no ACK is received Alexander Stein
@ 2011-06-28 10:18 ` Christian Gmeiner
[not found] ` <1309254219-18875-1-git-send-email-alexander.stein-93q1YBGzJSMe9JSWTWOYM3xStJ4P+DSV@public.gmane.org>
1 sibling, 0 replies; 3+ messages in thread
From: Christian Gmeiner @ 2011-06-28 10:18 UTC (permalink / raw)
To: Alexander Stein
Cc: Jean Delvare, Ben Dooks, Tomoya MORINAGA, linux-i2c, linux-kernel
Acked-by: Christian Gmeiner <christian.gmeiner@gmail.com>
--
Christian Gmeiner, MSc
^ permalink raw reply [flat|nested] 3+ messages in thread[parent not found: <1309254219-18875-1-git-send-email-alexander.stein-93q1YBGzJSMe9JSWTWOYM3xStJ4P+DSV@public.gmane.org>]
* Re: [PATCH] i2c-eg20t: Do not print error message if no ACK is received
[not found] ` <1309254219-18875-1-git-send-email-alexander.stein-93q1YBGzJSMe9JSWTWOYM3xStJ4P+DSV@public.gmane.org>
@ 2011-06-28 21:51 ` Ben Dooks
0 siblings, 0 replies; 3+ messages in thread
From: Ben Dooks @ 2011-06-28 21:51 UTC (permalink / raw)
To: Alexander Stein
Cc: Jean Delvare, Ben Dooks, Tomoya MORINAGA,
linux-i2c-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
On Tue, Jun 28, 2011 at 11:43:39AM +0200, Alexander Stein wrote:
> Doing so would spam the kernel log for each i2cdetect run and
> device probe.
>
> Signed-off-by: Alexander Stein <alexander.stein-93q1YBGzJSMe9JSWTWOYM3xStJ4P+DSV@public.gmane.org>
ok, will add to fixes for -rc.
> ---
> drivers/i2c/busses/i2c-eg20t.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-eg20t.c b/drivers/i2c/busses/i2c-eg20t.c
> index 8abfa4a..97110f7 100644
> --- a/drivers/i2c/busses/i2c-eg20t.c
> +++ b/drivers/i2c/busses/i2c-eg20t.c
> @@ -345,7 +345,7 @@ static s32 pch_i2c_getack(struct i2c_algo_pch_data *adap)
> reg_val = ioread32(p + PCH_I2CSR) & PCH_GETACK;
>
> if (reg_val != 0) {
> - pch_err(adap, "return%d\n", -EPROTO);
> + pch_dbg(adap, "return%d\n", -EPROTO);
> return -EPROTO;
> }
>
> --
> 1.7.3.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Ben Dooks, ben-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org, http://www.fluff.org/ben/
Large Hadron Colada: A large Pina Colada that makes the universe disappear.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-06-28 21:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-28 9:43 [PATCH] i2c-eg20t: Do not print error message if no ACK is received Alexander Stein
2011-06-28 10:18 ` Christian Gmeiner
[not found] ` <1309254219-18875-1-git-send-email-alexander.stein-93q1YBGzJSMe9JSWTWOYM3xStJ4P+DSV@public.gmane.org>
2011-06-28 21:51 ` Ben Dooks
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).