linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Worsley <amworsley-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org,
	ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org,
	jacmet-OfajU3CKLf1/SzgSGea1oA@public.gmane.org
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org
Subject: Re: i2c-ocores timeout bug
Date: Thu, 30 Jun 2011 08:55:42 +1000	[thread overview]
Message-ID: <BANLkTino1RYuDDjcXZYdJ1LyeSHz6h=ACw@mail.gmail.com> (raw)
In-Reply-To: <BANLkTikEESnV9+hc=VFg=qFGOXeg4o0sOQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

So far no response on this bug I reported about 2 weeks ago that
includes a proposed fix.

Could some one consider adding in the fix into the relevant tree?

On 15 June 2011 08:33, Andrew Worsley <amworsley-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> Hi, I have hit upon a bug in this driver in the 2.6.32 which caused
> memory corrupt and crash in my kernel. It appears to be still present
> in 3.0-rc3

http://thread.gmane.org/gmane.linux.drivers.i2c/8543

I have since identified the cause of the problem was the wrong clock
frequency for the FPGA. I mis-understood the clock frequency to
be the i2c bus frequency - but it is actually an FPGA clock frequency.
Perhaps others will make the same mistake as well.

In fact as it stands there is no module parameter to change your i2c
bus frequency - other than by fiddling your FPGA clock frequency.
Better would be a separate parameters for each with a clearer names.

Andrew

  parent reply	other threads:[~2011-06-29 22:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-14 22:33 i2c-ocores timeout bug Andrew Worsley
     [not found] ` <BANLkTikEESnV9+hc=VFg=qFGOXeg4o0sOQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-06-16 16:52   ` Jean Delvare
     [not found]     ` <20110616185209.08ef41ed-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2011-07-03 20:31       ` Peter Korsgaard
     [not found]         ` <87pqlr14z0.fsf-uXGAPMMVk8amE9MCos8gUmSdvHPH+/yF@public.gmane.org>
2011-07-03 23:45           ` Andrew Worsley
2011-06-29 22:55   ` Andrew Worsley [this message]
     [not found]     ` <BANLkTino1RYuDDjcXZYdJ1LyeSHz6h=ACw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-06-30  7:10       ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='BANLkTino1RYuDDjcXZYdJ1LyeSHz6h=ACw@mail.gmail.com' \
    --to=amworsley-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
    --cc=grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org \
    --cc=jacmet-OfajU3CKLf1/SzgSGea1oA@public.gmane.org \
    --cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).