linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chuansheng Liu <lcs0208@gmail.com>
To: Srinidhi Kasagar <srinidhi.kasagar@stericsson.com>
Cc: "linus.walleij@linaro.org" <linus.walleij@linaro.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Wolfram Sang <w.sang@pengutronix.de>,
	"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
	"chuansheng.liu@intel.com" <chuansheng.liu@intel.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/7] I2c-nomadik: Fix the usage of wait_for_completion_timeout
Date: Thu, 15 Nov 2012 18:52:36 +0800	[thread overview]
Message-ID: <C53EED5A-0C30-44EE-ADD5-6CBABFA3A0FE@gmail.com> (raw)
In-Reply-To: <20121115095741.GA6280@bnru10>


[-- Attachment #1.1: Type: text/plain, Size: 1118 bytes --]

timeout is never < 0, so status = timeout is never getting run. This patch delete pointless
code. Could you show the regression? Thanks.

在 2012-11-15，17:57，Srinidhi Kasagar <srinidhi.kasagar@stericsson.com> 写道：

> On Thu, Nov 15, 2012 at 10:29:53 +0100, Wolfram Sang wrote:
>> 
>>>> -       if (timeout < 0) {
>>>> -               dev_err(&dev->adev->dev,
>>>> -                       "wait_for_completion_timeout "
>>>> -                       "returned %d waiting for event\n", timeout);
>>>> -               status = timeout;
>>>> -       }
>>>> -
>>> No, it is wrong. You need to update the status variable in the case of timeout.
>> 
>> Looking at the patch context, such code comes later.
> But it causes regressions; without looking at the "later" code, we can't afford merging
> this code now.
> 
> regards/srinidhi
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

[-- Attachment #1.2: Type: text/html, Size: 3802 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

      parent reply	other threads:[~2012-11-15 10:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1352222317.15558.1584.camel@cliu38-desktop-build>
2012-11-12 17:26 ` [PATCH 1/7] I2c-nomadik: Fix the usage of wait_for_completion_timeout Wolfram Sang
2012-11-13  1:21   ` Liu, Chuansheng
2012-11-13  7:58     ` Wolfram Sang
     [not found]       ` <20121113075813.GA23119-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-11-13  8:00         ` Liu, Chuansheng
     [not found] ` <CACRpkdYekQF5111NSNSPeaHdxgS_gpXkCjqT1n-n1_iAdDXbSg@mail.gmail.com>
2012-11-15  8:49   ` Fwd: " Srinidhi Kasagar
2012-11-15  9:29     ` Wolfram Sang
     [not found]       ` <20121115092953.GA418-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-11-15  9:57         ` Srinidhi Kasagar
2012-11-15 10:18           ` Wolfram Sang
     [not found]             ` <20121115101820.GC418-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-11-15 11:18               ` Srinidhi Kasagar
2012-11-15 10:52           ` Chuansheng Liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C53EED5A-0C30-44EE-ADD5-6CBABFA3A0FE@gmail.com \
    --to=lcs0208@gmail.com \
    --cc=chuansheng.liu@intel.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=srinidhi.kasagar@stericsson.com \
    --cc=w.sang@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).