From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
Nicolas Saenz Julienne <nsaenz@kernel.org>,
Chris Brandt <Chris.Brandt@renesas.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-i2c <linux-i2c@vger.kernel.org>,
linux-rpi-kernel <linux-rpi-kernel@lists.infradead.org>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/3] i2c: sh_mobile: Use platform_get_irq_optional() to get the interrupt
Date: Sun, 26 Dec 2021 10:03:22 +0000 [thread overview]
Message-ID: <CA+V-a8vPfRK66BFgO9tQ8kBxC5OkXawmK_5shVMgq+NS97QfaA@mail.gmail.com> (raw)
In-Reply-To: <CAHp75VfzzVuVbP41B-02CT3EdEBoDh-Ewj2KAYdw7jdaHmFvzQ@mail.gmail.com>
On Sun, Dec 26, 2021 at 8:41 AM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Sun, Dec 26, 2021 at 1:45 AM Prabhakar Mahadev Lad
> <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
> > > On Wed, Dec 22, 2021 at 2:41 PM Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
>
> ...
>
> > > > + if (np) {
> > >
> > > Same comments as per your other patches, i.e.
> > > Why is this check here?
> > >
> > Because the interrupt resource has range of interrupts in one IRQ resource [0]. Let me know if there is any other alternative way to avoid such case.
>
> Shouldn't be fixed in platform_get_irq_optional() to return IRQ by
> index for all cases?
>
Sorry, I don't get you here. Wasn't your earlier comment for np check?
Cheers,
Prabhakar
next prev parent reply other threads:[~2021-12-26 10:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-21 17:53 [PATCH v2 0/3] i2c/busses: Use platform_get_irq/_optional() variants to fetch IRQ's Lad Prabhakar
2021-12-21 17:53 ` [PATCH v2 1/3] i2c: bcm2835: Use platform_get_irq() to get the interrupt Lad Prabhakar
2021-12-21 18:24 ` Florian Fainelli
2022-01-03 9:18 ` Wolfram Sang
2021-12-21 17:53 ` [PATCH v2 2/3] i2c: sh_mobile: Use platform_get_irq_optional() " Lad Prabhakar
2021-12-22 9:20 ` Geert Uytterhoeven
2021-12-22 9:49 ` Wolfram Sang
2021-12-25 17:48 ` Andy Shevchenko
2021-12-25 23:45 ` Prabhakar Mahadev Lad
2021-12-26 8:40 ` Andy Shevchenko
2021-12-26 10:03 ` Lad, Prabhakar [this message]
2022-01-03 9:19 ` Wolfram Sang
2021-12-21 17:53 ` [PATCH v2 3/3] i2c: riic: Use platform_get_irq() " Lad Prabhakar
2021-12-22 9:52 ` Wolfram Sang
2021-12-22 13:00 ` Geert Uytterhoeven
2022-01-03 9:19 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+V-a8vPfRK66BFgO9tQ8kBxC5OkXawmK_5shVMgq+NS97QfaA@mail.gmail.com \
--to=prabhakar.csengg@gmail.com \
--cc=Chris.Brandt@renesas.com \
--cc=andy.shevchenko@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=nsaenz@kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).