From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Courbot Subject: Re: [PATCH] gpio: extend gpiod_get*() with flags parameter Date: Fri, 25 Jul 2014 10:36:43 +0900 Message-ID: References: <1406214298-20062-1-git-send-email-acourbot@nvidia.com> <1496956.3bpx902hFg@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1496956.3bpx902hFg@avalon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart Cc: linux-wireless , Ulf Hansson , Wolfram Sang , linux-mmc , Chris Ball , "dri-devel@lists.freedesktop.org" , Liam Girdwood , Peter Ujfalusi , "linux-i2c@vger.kernel.org" , Pavel Machek , Jiri Slaby , Florian Fainelli , Samuel Ortiz , Alexander Shiyan , Dmitry Eremin-Solenikov , Lee Jones , Paul Handrigan , linux-iio@vger.kernel.org, linux-omap@vger.kernel.org, Tomi Valkeinen , Hans Verkuil , linux-serial@vger.kernel.org, linux-input@vger.kernel.o List-Id: linux-i2c@vger.kernel.org On Fri, Jul 25, 2014 at 1:23 AM, Laurent Pinchart wrote: >> diff --git a/Documentation/gpio/consumer.txt >> b/Documentation/gpio/consumer.txt index 7ff30d2..a3fb1d7 100644 >> --- a/Documentation/gpio/consumer.txt >> +++ b/Documentation/gpio/consumer.txt >> @@ -29,13 +29,24 @@ gpiod_get() functions. Like many other kernel >> subsystems, gpiod_get() takes the device that will use the GPIO and the >> function the requested GPIO is supposed to fulfill: >> >> - struct gpio_desc *gpiod_get(struct device *dev, const char *con_id) >> + struct gpio_desc *gpiod_get(struct device *dev, const char *con_id, >> + enum gpio_flags flags) > > I assume you mean enum gpiod_flags here and in the rest of the documentation. Indeed, thanks for pointing it out. > >> If a function is implemented by using several GPIOs together (e.g. a simple >> LED device that displays digits), an additional index argument can be >> specified: >> >> struct gpio_desc *gpiod_get_index(struct device *dev, >> - const char *con_id, unsigned int idx) >> + const char *con_id, unsigned int idx, >> + enum gpio_flags flags) >> + >> +The flags parameter is used to optionally specify a direction and initial >> value +for the GPIO. Values can be: >> + >> +* AS_IS or 0 to not initialize the GPIO at all. The direction must be set >> later >> + with one of the dedicated functions. >> +* INPUT to initialize the GPIO as input. >> +* OUTPUT_LOW to initialize the GPIO as output with a value of 0. >> +* OUTPUT_HIGH to initialize the GPIO as output with a value of 1. > > Pretty please, could you at least prefix that with GPIOD_ ? Those names are > too generic. > > How about renaming them to GPIOD_AS_IS, GPIOD_IN, GPIOD_OUT_INIT_LOW and > GPIOD_OUT_INIT_HIGH in order to match the GPIOF_ flags ? Yeah, you're right, the possibility of name collision is quite high here. Thanks, Alex.