From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eugeni Dodonov Subject: Re: [PATCH] drm/i915: i2c: unconditionally set up gpio fallback Date: Mon, 27 Feb 2012 15:29:56 -0300 Message-ID: References: <1330366963-12623-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0266491536==" Return-path: In-Reply-To: <1330366963-12623-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: Intel Graphics Development , linux-i2c@vger.kernel.org, DRI Development List-Id: linux-i2c@vger.kernel.org --===============0266491536== Content-Type: multipart/alternative; boundary=e89a8ff254b075000e04b9f64edd --e89a8ff254b075000e04b9f64edd Content-Type: text/plain; charset=ISO-8859-1 On Mon, Feb 27, 2012 at 15:22, Daniel Vetter wrote: > This way we can simplify the setup and teardown a bit. > > Because we don't actually allocate anything anymore for the force_bit > case, we can now convert that into a boolean. > > Also and the functionality supported by the bit-banging together with > what gmbus can do, so that this doesn't randomly change any more. > > v2: Chris Wilson noticed that I've mixed up && and & ... > > v3: Clarify an if block as suggested by Eugeni Dodonov. > > Signed-Off-by: Daniel Vetter > Reviewed-by: Eugeni Dodonov -- Eugeni Dodonov --e89a8ff254b075000e04b9f64edd Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
On Mon, Feb 27, 2012 at 15:22, Daniel Vetter <daniel.vetter@= ffwll.ch> wrote:
This way we can simplify the setup and teardown a bit.
Because we don't actually allocate anything anymore for the force_bit case, we can now convert that into a boolean.

Also and the functionality supported by the bit-banging together with
what gmbus can do, so that this doesn't randomly change any more.

v2: Chris Wilson noticed that I've mixed up && and & ...
v3: Clarify an if block as suggested by Eugeni Dodonov.

Signed-Off-by: Daniel Vetter <= daniel.vetter@ffwll.ch>

Reviewed-by: = Eugeni Dodonov <eugeni.dodon= ov@intel.com>

--
Eugeni Dodonov

--e89a8ff254b075000e04b9f64edd-- --===============0266491536== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0266491536==--