From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH 3/4] gpio: Kontron PLD gpio driver Date: Tue, 9 Apr 2013 10:46:15 +0200 Message-ID: References: <1365441321-21952-1-git-send-email-kevin.strasser@linux.intel.com> <1365441321-21952-3-git-send-email-kevin.strasser@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: In-Reply-To: <1365441321-21952-3-git-send-email-kevin.strasser@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org To: Kevin Strasser Cc: "linux-kernel@vger.kernel.org" , Michael Brunner , Samuel Ortiz , Wolfram Sang , Ben Dooks , "linux-i2c@vger.kernel.org" , Grant Likely , Wim Van Sebroeck , linux-watchdog@vger.kernel.org, Darren Hart , Michael Brunner , Greg Kroah-Hartman List-Id: linux-i2c@vger.kernel.org On Mon, Apr 8, 2013 at 7:15 PM, Kevin Strasser wrote: > From: Michael Brunner > > Add gpio support for the on-board PLD found on some Kontron embedded > modules. > > Signed-off-by: Michael Brunner > Signed-off-by: Kevin Strasser This looks very generic, setting and clearing bits in bytesized registers. Can you please attempt to use generic GPIO for this? drivers/gpio/gpio-generic.c See for example: gpio-ep93xx.c, gpio-sodaville.c ... Since you don't even have IRQ support in this it will be even simpler. Yours, Linus Walleij