From: Linus Walleij <linus.walleij@linaro.org>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-i2c@vger.kernel.org,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Phil Reid <preid@electromag.com.au>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Claudio Foellmi <claudio.foellmi@ergon.ch>,
Andrzej Hajda <a.hajda@samsung.com>
Subject: Re: [PATCH 3/6] i2c: add 'set_sda' to bus_recovery_info
Date: Tue, 5 Dec 2017 16:31:14 +0100 [thread overview]
Message-ID: <CACRpkdYuHit1w1_d4h++vOuSWosf+iBdgimtCUbmic3mkbm1Wg@mail.gmail.com> (raw)
In-Reply-To: <20171205133848.nzrhysiz2twvlamx@ninjato>
On Tue, Dec 5, 2017 at 2:38 PM, Wolfram Sang <wsa@the-dreams.de> wrote:
>> Just compare it to zero. if (!gpiod_get_direction())
>
> So, this?
>
> if (!gpiod_get_direction())
> bri->set_sda = set_sda_gpio_value;
>
> That looks like "if i couldn't the direction, then...", or?
>
> Comparing to plain numbers feels like magic values?
Hehe :)
> Maybe this should be named 'gpiod_is_direction_input()'?
Two statice inlines in <linux/gpio/consumer.h>
named
int gpiod_is output()
int gpiod_is_input()
should conform to Rusty Russell's API hierarchy.
Interested in fixing it, or should I?
I can almost ACK it before you write the patch.
Yours,
Linus Walleij
next prev parent reply other threads:[~2017-12-05 15:31 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20171204123700epcas2p4273f3313a4c52e7685bbf04d776cbcef@epcas2p4.samsung.com>
2017-12-04 12:36 ` [PATCH 0/6] i2c: send STOP after recovery; use it for i2c-rcar Wolfram Sang
2017-12-04 12:36 ` [PATCH 1/6] i2c: make kerneldoc about bus recovery more precise Wolfram Sang
2017-12-04 12:36 ` [PATCH 2/6] i2c: add identifier in declarations for i2c_bus_recovery Wolfram Sang
2017-12-13 15:23 ` Andy Shevchenko
2018-01-09 11:17 ` Wolfram Sang
2017-12-04 12:36 ` [PATCH 3/6] i2c: add 'set_sda' to bus_recovery_info Wolfram Sang
2017-12-05 1:12 ` Phil Reid
2017-12-05 8:39 ` Linus Walleij
2017-12-05 9:57 ` Phil Reid
2017-12-05 10:32 ` Wolfram Sang
2017-12-05 10:34 ` Linus Walleij
2017-12-05 13:38 ` Wolfram Sang
2017-12-05 15:31 ` Linus Walleij [this message]
2017-12-05 16:43 ` Wolfram Sang
2017-12-07 11:25 ` Wolfram Sang
2017-12-10 0:24 ` Linus Walleij
2017-12-13 15:30 ` Andy Shevchenko
2018-01-09 11:23 ` Wolfram Sang
2017-12-13 15:27 ` Andy Shevchenko
2017-12-04 12:36 ` [PATCH 4/6] i2c: ensure SDA is released in recovery if SDA is controllable Wolfram Sang
2017-12-04 12:36 ` [PATCH 5/6] i2c: send STOP after successful bus recovery Wolfram Sang
2017-12-04 12:36 ` [PATCH 6/6] i2c: rcar: implement " Wolfram Sang
2017-12-05 1:13 ` [PATCH 0/6] i2c: send STOP after recovery; use it for i2c-rcar Phil Reid
2017-12-05 9:21 ` Andrzej Hajda
2018-01-09 11:15 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdYuHit1w1_d4h++vOuSWosf+iBdgimtCUbmic3mkbm1Wg@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=a.hajda@samsung.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=claudio.foellmi@ergon.ch \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=preid@electromag.com.au \
--cc=wsa+renesas@sang-engineering.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).