From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Anderson Subject: Re: [PATCH v3] i2c: s3c2410: dont need CPU_FREQ transitions for exynos series Date: Mon, 25 Nov 2013 15:41:43 -0800 Message-ID: References: <1381490814-20890-1-git-send-email-ch.naveen@samsung.com> <1384841915-8264-1-git-send-email-ch.naveen@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: In-Reply-To: <1384841915-8264-1-git-send-email-ch.naveen@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org To: Naveen Krishna Chatradhi Cc: "linux-i2c@vger.kernel.org" , Simon Glass , "linux-kernel@vger.kernel.org" , linux-samsung-soc , Wolfram Sang , Ben Dooks , Grant Likely , "broonie@kernel.org" , "cpgs ." , Tomasz Figa List-Id: linux-i2c@vger.kernel.org Naveen, On Mon, Nov 18, 2013 at 10:18 PM, Naveen Krishna Chatradhi wrote: > For Exynos4 and Exynos5 SoCs from Samsung the i2c clock is based > on a fixed 66 MHz peripheral clock, and therefore is completely > independent of the cpu frequency. > Thus, registering for a CPU freq notifier is very wasteful. > > This patch modifes the code such that, i2c bus registers to > cpu_freq_transition only if CONFIG_CPU_FREQ_S3C24XX is enabled. > > This change should save a bunch of cpufreq transitions calls > which does not apply to exynos SoCs. > > Signed-off-by: Naveen Krishna Chatradhi > Acked-by: Kyungmin Park > Reviewed-by: Doug Anderson > --- > Changes since v2: > None, Rebased on for-next of linux-i2c git repo. > > Changes since v1: > Use CONFIG_CPU_FREQ_S3C24XX instead of (CONFIG_CPU_FREQ & !CONFIG_EXYNOS) > As commented by Tomasz > > drivers/i2c/busses/i2c-s3c2410.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Can you please spin this with comments from ? Thanks! -Doug