linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Leo Li <pku.leo@gmail.com>
To: Tracy Smith <tlsmith3777@gmail.com>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
	"Wolfram Sang" <wsa@the-dreams.de>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	linux-gpio@vger.kernel.org, "Li Yang" <leoyang.li@nxp.com>,
	"Stefan Agner" <stefan@agner.ch>, "Gao Pan" <pandy.gao@nxp.com>,
	lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5] i2c: imx: make bus recovery through pinctrl optional
Date: Mon, 12 Sep 2016 11:35:39 -0500	[thread overview]
Message-ID: <CADRPPNSLZ-Ck+40LZLdpEXPaBm+61AtrpRPgAcTCojWSsTBQDw@mail.gmail.com> (raw)
In-Reply-To: <CAChUvXMPDZB7=ZArQ5+6ae42N=Bsgv_OczGXnyhBjEdjt_yvsw@mail.gmail.com>

On Wed, Sep 7, 2016 at 5:07 AM, Tracy Smith <tlsmith3777@gmail.com> wrote:
> Hello, bus recovery is needed generally speaking because of potential
> protocol errors that might cause a failure condition hanging the bus.
>
> It happens frequently during bring-up of new I2C devices because firmware in
> I2C controllers fail to handle properly protocol errors.
>
> Can NXP add bus recovery for the LS1021A and LS1043A in a separate patch--
> unless there is no HW bus recovery mechanism?
>
> The concern is while fixing I.MX, NXP will fail to fix the driver bus
> recovery for the LS1021A and LS1043A and the bus will hang.
>
> If bus recovery is supported on the LS1021A and the LS1043A, a patch should
> be provided or added in this patch instead of simply disabling bus recovery.
> Request NXP to consider the patch if there is HW support for bus recovery.

FYI.  http://patchwork.ozlabs.org/patch/573879/  This seem to be the
patch you are asking for.  I have asked the original developer to
update the patch according to Wolfram's comment and work together with
the current pinctrl/gpio based recovery.  In the meanwhile you can
make use of the patch for now for LS1021A and LS1043A if necessary.

Regards,
Leo

  parent reply	other threads:[~2016-09-12 16:35 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-19 22:05 [PATCH v5] i2c: imx: make bus recovery through pinctrl optional Li Yang
2016-09-06 18:58 ` Uwe Kleine-König
2016-09-06 20:06   ` Leo Li
2016-09-06 21:07     ` Uwe Kleine-König
2016-09-06 23:14       ` Leo Li
2016-09-06 21:51     ` Stefan Agner
2016-09-06 22:40       ` Leo Li
     [not found]         ` <CAChUvXOGjTn6K5588UVgjbRWUY+weDtk2qbOU-NM4=kA2znh=Q@mail.gmail.com>
2016-09-07  5:55           ` Uwe Kleine-König
     [not found]             ` <CAChUvXMPDZB7=ZArQ5+6ae42N=Bsgv_OczGXnyhBjEdjt_yvsw@mail.gmail.com>
2016-09-07 16:40               ` Leo Li
2016-09-12 16:35               ` Leo Li [this message]
2016-09-12 18:29                 ` Leo Li
2016-09-08 22:39         ` Stefan Agner
2016-09-08 23:57           ` Leo Li
2016-09-09 16:51             ` Stefan Agner
2016-09-09 19:37               ` Leo Li
2016-09-09 20:34                 ` Stefan Agner
2016-09-09 20:59                   ` Uwe Kleine-König
2016-09-12 16:47                     ` Leo Li
2016-09-12  8:21                 ` Lothar Waßmann
2016-09-12 16:27                   ` Leo Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADRPPNSLZ-Ck+40LZLdpEXPaBm+61AtrpRPgAcTCojWSsTBQDw@mail.gmail.com \
    --to=pku.leo@gmail.com \
    --cc=leoyang.li@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pandy.gao@nxp.com \
    --cc=stefan@agner.ch \
    --cc=tlsmith3777@gmail.com \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).