From: Alex Deucher <alexdeucher-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Jean Delvare <jdelvare-l3A5Bk7waGM@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/2] i2c-algo-bit: Be verbose on bus testing failure
Date: Tue, 4 Oct 2011 09:22:31 -0400 [thread overview]
Message-ID: <CADnq5_MeOx3MT7B8d_2bkQyoeG6Z9FvixwdQO1cpWL=mttmtTw@mail.gmail.com> (raw)
In-Reply-To: <201110041445.57054.jdelvare-l3A5Bk7waGM@public.gmane.org>
On Tue, Oct 4, 2011 at 8:45 AM, Jean Delvare <jdelvare-l3A5Bk7waGM@public.gmane.org> wrote:
> If bus testing fails due to the bus being seen as busy, it might be
> helpful for developers to know which line is unexpectedly low.
>
> Signed-off-by: Jean Delvare <jdelvare-l3A5Bk7waGM@public.gmane.org>
> Cc: Alex Deucher <alexdeucher-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Reviewed-by: Alex Deucher <alexdeucher-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
> drivers/i2c/algos/i2c-algo-bit.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> --- linux-3.0.orig/drivers/i2c/algos/i2c-algo-bit.c 2011-10-03 18:50:34.000000000 +0200
> +++ linux-3.0/drivers/i2c/algos/i2c-algo-bit.c 2011-10-03 18:55:14.000000000 +0200
> @@ -250,7 +250,9 @@ static int test_bus(struct i2c_adapter *
> sda = getsda(adap);
> scl = (adap->getscl == NULL) ? 1 : getscl(adap);
> if (!scl || !sda) {
> - printk(KERN_WARNING "%s: bus seems to be busy\n", name);
> + printk(KERN_WARNING
> + "%s: bus seems to be busy (scl=%d, sda=%d)\n",
> + name, scl, sda);
> goto bailout;
> }
>
>
> --
> Jean Delvare
> Suse L3
>
prev parent reply other threads:[~2011-10-04 13:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-04 12:45 [PATCH 2/2] i2c-algo-bit: Be verbose on bus testing failure Jean Delvare
[not found] ` <201110041445.57054.jdelvare-l3A5Bk7waGM@public.gmane.org>
2011-10-04 13:22 ` Alex Deucher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADnq5_MeOx3MT7B8d_2bkQyoeG6Z9FvixwdQO1cpWL=mttmtTw@mail.gmail.com' \
--to=alexdeucher-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=jdelvare-l3A5Bk7waGM@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).